Conversation
madhusudhand
requested review from
pbking,
t-hamano and
vcanales
and removed request for
pbking and
t-hamano
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
The Modal component can now define its width via the size prop. What do you think about using this prop instead of defining width in CSS? However, when using this props, the modal's height will not be full.
<Modal
size="large"
>
</Modal>
madhusudhand
force-pushed
the
update-modal-ui
branch
from
b587221 to
1e81d13
Compare
|
What if additionally we shifted the 'screenshot' and 'subfolder' (two items that are pretty narrow) to a second, smaller column on the right? 
|
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
I think this is an interesting idea and may be considered in another PR. |
pbking
left a comment
pbking
left a comment
There was a problem hiding this comment.
I merged /trunk and fixed a conflict and I think this is ready to come in too. It looks nice; thank you for doing this. :)
|
I fixed the conflicts to merge this and include it in the next release. |
4 participants
This change brings the following UI changes.
65vw(similar to font library in core)In addition to these UI changes, it also introduces a style-sheet for adding class definitions.