Conversation
pbking
force-pushed
the
replace/admin-interface
branch
from
169b685 to
49757a5
Compare
|
I did a quick mockup of what this interface could look like, with a clearer content hierarchy and CTA's. The modal you shared above looks good to me when clicking each option.
|
pbking
force-pushed
the
replace/admin-interface
branch
from
ea0e703 to
94e4d43
Compare
Gives us smaller filesizes.
vcanales
left a comment
vcanales
left a comment
There was a problem hiding this comment.
Took the liberty to:
- Add missing translations
- Change FAQ images to webp, which gives us a smaller filesize
Co-authored-by: Vicente Canales <1157901+vcanales@users.noreply.github.com>
vcanales
left a comment
vcanales
left a comment
There was a problem hiding this comment.
Looking good! Just a few nitpicks regarding eslint rule deactivation
|
I believe all of the feedback has been addressed with one exception (that I'm not sure I understand). There was some great reviewing in here! Maybe ready for another look? |
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
h1 no longer exists in the content 😅 I suggest making the title logo an h1, what do you think? In that case, I think we need to change the image alt from Create Block Theme Logo to Create Block Theme.
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the update! I have made additional suggestions.
Another thing that bothers me is that the translation files don't seem to be loading.
This plugin is already translated into several locales. And if I switch the site language to that locale, the script with the handle create-block-theme-app-js-translations should be enqueued, but it isn't.
For example, it is 100% translated in the Japanese locale, and the editor sidebar is fully translated. I was hoping that this new admin page would translate at least some of it, but it doesn't translate at all.
Will this not be translated unless the plugin is released and reflected in GlotPress?
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Co-authored-by: Vicente Canales <1157901+vcanales@users.noreply.github.com>
|
Latest round of adjustments are in. Ready for another review I think! |
I've no idea why the translations wouldn't be working as expected. That might be related... Should we release this change and see? |
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
LGTM 🚀
I think if we address the comment left by @vcanales, we can ship this PR.
Another thing that bothers me is that the translation files don't seem to be loading.
I checked the return value of wp_set_script_translations() and it is true, so there should be no problem with the implementation. Let's see if the translations will be reflected when this version is released and localized.
Co-authored-by: Vicente Canales <1157901+vcanales@users.noreply.github.com>
5 participants
Replace the wp-admin interface with a React app that does the following: