Use only major.minor version in 'Tested up to' field#635
Merged
Conversation
…on with major.minor only
Closed
matiasbenedetto
approved these changes
May 14, 2024
Contributor
matiasbenedetto
left a comment
matiasbenedetto
left a comment
There was a problem hiding this comment.
I added a docblock to the function added.
Apart from that it looks good to me.
vcanales
reviewed
May 14, 2024
vcanales
reviewed
May 14, 2024
Member
vcanales
left a comment
vcanales
left a comment
There was a problem hiding this comment.
I think this function is a great candidate for a unit test, rather than testing it by calling it from another class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swap get_bloginfo('version') with custom function that supplies version with major.minor only.
Fixes #523
To Test:
Using CBT update metadata.
Note that the "Tested Up to" shows the version of WordPress being used with only MAJOR.MINOR in style.css and readme.txt