Add prefix to the names in the PHP global namespace.#628
Merged
Conversation
vcanales
approved these changes
May 13, 2024
Member
vcanales
left a comment
vcanales
left a comment
There was a problem hiding this comment.
This looks good. We might want to merge soon, since this impacts most of the codebase, the longer we wait, it'll get harder and harder to resolve conflicts.
Contributor
|
I brought trunk in and refactored the readme file changes. Looks fine now. I agree that this should be brought in sooner than later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add prefixes to the names in the PHP global namespace.
Why?
Fixes: #627