Repository navigation
Bump version to 1.2.0-beta.2 - #520
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: WordPress/contributor-toolkit/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
v1.2.0-beta.1shipped on 20 September. Eight commits reach trunk since then, all of them what the beta.1 pass and the review of its fixes turned up, on macOS and on Windows: a Gutenberg trunk update and a work-item switch no longer rebuild twice, the applied banner follows the watch, Windows no longer opens console windows for a Gutenberg build nor hangs on an orphaned worker, and macOS no longer fills the Dock with a tile per build worker. Thev1.2.0-beta.2milestone is empty.electron-builderderives artifact names frompackage.json, so the version has to move before the tag and the artifacts exist. A beta is a pre-release, soreleases/lateststays onv1.1.0.What changes
Only the version. All three package-version fields in
package.jsonandpackage-lock.jsonmove together from1.2.0-beta.1to1.2.0-beta.2. No dependency versions change, and there is no application behaviour change in this PR.How to test this
Platforms: any for the suite; macOS and Windows for the artifact checks that follow the merge.
npm run lintis clean andnpm testpasses, from the repository root.node -e "console.log(require('./package.json').version)"prints1.2.0-beta.2.python3 -c "import json;d=json.load(open('package-lock.json'));print(d['version'], d['packages']['']['version'])"prints1.2.0-beta.2 1.2.0-beta.2.What must not have happened: no dependency version may change.
git diffmust show exactly three changed lines, all of them the root package version.After merge, the release build must produce artifacts named
wordpress-contributor-toolkit-1.2.0-beta.2-*; the asar root must be exactlynode_modules,package.json,src, with npm 11 undernode_modules/npmand no.codesigningdirectory; on macOSCFBundleShortVersionStringreads1.2.0-beta.2.Risks and limitations
No UI change. The risk is a mis-scoped edit in
package-lock.json, where dependencies also carry version fields; the replacement was confined to the first 2000 bytes of the file, which hold the two root entries and nothing else, and both files were re-parsed as JSON afterwards.Verified locally on this branch: lint clean,
npm test1646 pass / 0 fail,git diffis 3 insertions and 3 deletions across the two files.Related
Part of #251. Release notes follow on the pre-release; docs publish for the tag per #487.
Review outcome (required — see AGENTS.md)
0 [fix here] · 0 [follow-up]. Deterministic layer only: lint clean, 1646 tests pass, both files valid JSON, diff confined to the three root version fields. No judgement pass was run: this change has no logic to review.
229d3eb(trunk); evidence above; outcome: nothing to fix.🤖 Generated with Claude Code