Repository navigation
[Docs] A pull request you did not open belongs to its author - #456
Merged
Merged
Conversation
An agent pushed a rebase fix to an external contributor's branch because the repository allowed maintainer edits and the fix was one line. That is not the agent's call: the author owns their branch and their merge. On a pull request the person you work for did not open, the only move is to review and leave findings. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0123opUnXoxs1CAN7YQ7q8KU
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
An agent found two rebase breakages on an external contributor's pull request (#358): trunk had removed two exports the branch still imported. The repository allows maintainer edits on that branch and each fix was one line, so the agent pushed a merge and a fix commit to the contributor's fork. Nothing in
AGENTS.mdsaid not to.That is the author's call, not the agent's. A contributor's branch is theirs: what lands on it, and when it merges, is decided by whoever opened the pull request. The right move on a pull request the person you work for did not open is a review with the findings written down.
What changes
One section in
AGENTS.md, under "Before opening a pull request": a pull request you did not open belongs to its author. No pushes, rebases, description edits or merges on it, whatever the branch permissions say and however small the fix. Reviewing it and leaving findings, with a diff where that helps, is what an agent may do. If the author is unresponsive and the work is urgent, the agent says so and lets the person decide how to reach them.How to test this
Platforms: any. Documentation only, nothing runs.
Starting state: any checkout of this branch.
AGENTS.mdand find the section "A pull request you did not open belongs to its author". It sits between the CodeRabbit paragraphs and "The pull request description follows the template".What must not have happened: no other line of
AGENTS.mdchanged.git diff trunk --statlists one file with six added lines.Risks and limitations
None to the app. The rule constrains agents only; a human maintainer keeps whatever latitude the repository gives them.
Related
Prompted by #358, where the rule was broken before it existed.
Review outcome (required — see AGENTS.md)
Documentation change, six added lines in
AGENTS.md, no code. Read once against the surrounding sections for tone and placement;npm run lintdoes not cover Markdown. Nothing to fix, nothing deferred.Screenshots or recording
Nothing on screen changes.
🤖 Generated with Claude Code
https://claude.ai/code/session_0123opUnXoxs1CAN7YQ7q8KU