Skip to content

Commit eb7be4f

Browse files
ryanwelcherryanwelcher
committed
Say what a failed apply does with the file list
A switch that fails part-way keeps the list until the next walk answers, rather than clearing it. Said in the hook's comment, from the review of the previous commit. Refs #669
1 parent 5f556a7 commit eb7be4f

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

‎src/renderer/hooks/use-apply-patch.jsx‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,10 @@ import { watchOccupiesBuild } from '../watch-waiters.cjs';
3737
// `tracTicket`, `appliedPatch` and `pullRequest` are what the site's status
3838
// says is linked, applied and checked out. `loadStatus` and `refreshDirty`
3939
// re-read the site once the tree has changed. `forgetChangedFiles` also drops
40-
// the file list from before a change that wrote (#669); a refusal wrote
41-
// nothing, so its list stands. `confirm` announces an outcome.
40+
// the file list from before a change that wrote (#669). A failed exit keeps
41+
// the list until the walk answers: a refusal wrote nothing, and a switch
42+
// that failed part-way is rare enough to be put right by that walk alone.
43+
// `confirm` announces an outcome.
4244
// `showTracCards` and `isActive` say whether this project has Trac's
4345
// attachments and whether this site is the one in front, which is when its
4446
// ticket's pull requests are fetched. `project` and `workItem` name the

0 commit comments

Comments
 (0)