Skip to content

Fix plugin review items#111

Merged
jeffpaul merged 3 commits intoWordPress:developfrom
dkotter:fix/plugin-review
Nov 28, 2025
Merged

Fix plugin review items#111
jeffpaul merged 3 commits intoWordPress:developfrom
dkotter:fix/plugin-review

Conversation

@dkotter
Copy link
Copy Markdown
Collaborator

@dkotter dkotter commented Nov 27, 2025

What?

Closes #110

A few minor things were flagged during the plugin review process and this PR fixes those.

Why?

In order to get the plugin on WordPress.org, we need to ensure we pass the plugin review.

How?

  • Switches to a more specific namespace for all constants and hooks, AI_EXPERIMENTS and ai_experiments (these are pretty lengthy so open to suggestions if we want to shorten this)
  • Adds slightly more specific testing instructions to the readme.txt

Testing Instructions

Verify all changes look good here and all existing functionality still works

@dkotter dkotter self-assigned this Nov 27, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 27, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dkotter <dkotter@git.wordpress.org>
Co-authored-by: jeffpaul <jeffpaul@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: justlevine <justlevine@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 27, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 30.76923% with 18 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@d2d1902). Learn more about missing BASE report.

Files with missing lines Patch % Lines
includes/bootstrap.php 0.00% 10 Missing ⚠️
includes/Asset_Loader.php 0.00% 4 Missing ⚠️
ai.php 0.00% 2 Missing ⚠️
includes/Abilities/Utilities/Posts.php 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             develop     #111   +/-   ##
==========================================
  Coverage           ?   29.61%           
  Complexity         ?      145           
==========================================
  Files              ?       14           
  Lines              ?      878           
  Branches           ?        0           
==========================================
  Hits               ?      260           
  Misses             ?      618           
  Partials           ?        0
Flag Coverage Δ
unit 29.61% <30.76%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dkotter dkotter requested a review from jeffpaul November 27, 2025 03:00
@jeffpaul jeffpaul added this to the 0.2.0 milestone Nov 27, 2025
jeffpaul
jeffpaul reviewed Nov 27, 2025
View reviewed changes
docs/DEVELOPER_GUIDE.md

```php
add_filter( 'ai_experiment_example-experiment_enabled', '__return_false' );
add_filter( 'ai_experiments_experiment_example-experiment_enabled', '__return_false' );
Copy link
Copy Markdown
Member

@jeffpaul jeffpaul Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:alot: of experiment

@jeffpaul
Copy link
Copy Markdown
Member

jeffpaul commented Nov 27, 2025

@dkotter I'm good with these changes, so if you want to share a ZIP from this branch then I can get that over to WPORG while we allow others here to formalize a review (and perhaps iterate on the namespace if desired).

@dkotter
Copy link
Copy Markdown
Collaborator Author

dkotter commented Nov 27, 2025

Zip attached here
ai-0.1.0.zip

justlevine
justlevine approved these changes Nov 27, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@justlevine justlevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only reviewed the diff from my phone and LGTM, approving since I agree we shouldn't hold things up over naming things.

And tbh it's not even that long (iirc perf is performance-lab)

Above said,

I saw they said no to ai and the guidelines prevent wp, but did they say no to wpai together (no hyphen)? It's short, unambiguous, and follows the plugin naming guidelines.

@jeffpaul
Copy link
Copy Markdown
Member

jeffpaul commented Nov 27, 2025

I'll ask about wpai when I send the email response back but for now will keep the longer option in the code.

@jeffpaul jeffpaul merged commit 19c0842 into WordPress:develop Nov 28, 2025
27 of 28 checks passed
@jeffpaul
Copy link
Copy Markdown
Member

jeffpaul commented Dec 1, 2025

I'll ask about wpai when I send the email response back but for now will keep the longer option in the code.

TLDR; best to stick with the longer ai_experiments

That naming is discouraged as in this context 4 characters slugs that begin with wp- are in practice 2 characters slugs (wp + 2 characters).
A lot of people like to begin their stuff with "wp", that was actually one of the reasons we are now asking for 4 character prefixes instead of 3, that's because we detected a bunch of plugins using combinations like: wpa_, wpb_, wpc_, etc.

So I'll leave things as-is with the ai_experiments namespace.

@dkotter dkotter deleted the fix/plugin-review branch December 1, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffpaul jeffpaul jeffpaul left review comments

@swissspidy swissspidy swissspidy approved these changes

@justlevine justlevine justlevine approved these changes

@JasonTheAdams JasonTheAdams Awaiting requested review from JasonTheAdams

@felixarntz felixarntz Awaiting requested review from felixarntz

Assignees

@dkotter dkotter

Labels

None yet

Projects

None yet

Milestone

0.1.1

Development

Successfully merging this pull request may close these issues.

Resolve issues reported by WPORG plugin review

4 participants

@dkotter @jeffpaul @swissspidy @justlevine