Skip to content

Add core/post-types-query ability #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jorgefilipecosta wants to merge 13 commits into
base: develop
Choose a base branch
from
+2,232 −4
Draft

Add core/post-types-query ability #1106

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
cb4ac36
Add the core/post-types-query ability
jorgefilipecosta Oct 2, 2026
82b1a27
Gate core/post-types-query behind the Custom Abilities experiment
jorgefilipecosta Oct 2, 2026
99b1903
Port the post types controller tests to core/post-types-query
jorgefilipecosta Oct 2, 2026
7dde32d
Test the core/post-types-query modes, access, and REST parity
jorgefilipecosta Oct 2, 2026
3394cf1
Add an e2e spec for core/post-types-query
jorgefilipecosta Oct 2, 2026
b4740c8
Ignore the PHPStan nullable template check
jorgefilipecosta Oct 2, 2026
cc28f6e
Require edit access for fields nested in edit-only fields
jorgefilipecosta Oct 2, 2026
2148c9e
Report invalid list input against the list mode
jorgefilipecosta Oct 2, 2026
f8c42b0
Describe how edit-only fields limit the post types list
jorgefilipecosta Oct 2, 2026
f1b1de6
Name WP_Ability::execute() as the caller that hides permission errors
jorgefilipecosta Oct 2, 2026
863cdf0
Assert the REST status before reading its error
jorgefilipecosta Oct 2, 2026
09d1149
Fold the hidden post type test into the exposure helper
jorgefilipecosta Oct 2, 2026
27a385f
Drop post types tests that other tests cover
jorgefilipecosta Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fold the hidden post type test into the exposure helper
  • Loading branch information
@jorgefilipecosta
jorgefilipecosta committed Oct 2, 2026
commit 09d114920255a4c828036637c902e4c8e9a54aa0
31 changes: 1 addition & 30 deletions tests/Integration/Includes/Abilities/Post_Types/Post_TypesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,36 +590,6 @@ public function test_post_type_without_rest_is_exposed_by_opt_in(): void {
$this->assertSame( 'rest_cannot_read_type', $response->as_error()->get_error_code(), 'REST should not serve the post type.' );
}

/**
* A hidden post type and a missing one cannot be told apart.
*
* @since x.x.x
*/
public function test_hidden_and_missing_post_types_are_denied_alike(): void {
$this->register_test_post_type(
'wpai_hidden',
array(
'public' => true,
'show_in_rest' => true,
)
);
$this->login_as( 'administrator' );
$this->register_ability();

$hidden = array( 'slug' => 'wpai_hidden' );
$missing = array( 'slug' => 'wpai_missing' );

$post_types = new Post_Types();
$this->assertFalse( $post_types->check_permission( $hidden ), 'A hidden post type should be denied.' );
$this->assertFalse( $post_types->check_permission( $missing ), 'A missing post type should be denied.' );
$this->assertEquals( $post_types->execute_post_types_query( $missing ), $post_types->execute_post_types_query( $hidden ), 'A direct call should report a hidden post type like a missing one.' );

$hidden_result = $this->query_post_types( $hidden );
$missing_result = $this->query_post_types( $missing );
$this->assertAbilityError( $hidden_result, 'ability_invalid_input', 'A hidden post type should fail validation.' );
$this->assertEquals( $missing_result, $hidden_result, 'A hidden post type should fail validation like a missing one.' );
}

/**
* A post type hidden after the ability registered is denied like one unregistered since.
*
Expand Down Expand Up @@ -879,6 +849,7 @@ private function assert_post_type_is_not_exposed( string $post_type ): void {
$this->assertNotContains( $post_type, $slugs, "The {$post_type} post type should not be listed in the edit context." );

$this->assertAbilityError( $this->query_post_types( array( 'slug' => $post_type ) ), 'ability_invalid_input', "The {$post_type} post type should fail validation." );
$this->assertFalse( ( new Post_Types() )->check_permission( array( 'slug' => $post_type ) ), "The permission callback should deny the {$post_type} post type." );

$result = ( new Post_Types() )->execute_post_types_query( array( 'slug' => $post_type ) );
$this->assertAbilityError( $result, 'post_types_type_invalid', "A direct call should report the {$post_type} post type as invalid." );
Expand Down
Loading