Repository navigation
Content Classification: Align suggestion pill focus styles with the core Button - #1060
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1060 +/- ##
==========================================
Coverage 80.87% 80.87%
Complexity 2998 2998
==========================================
Files 124 124
Lines 11987 11987
==========================================
Hits 9695 9695
Misses 2292 2292
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
What, Why, and How?
The Content Classification suggestion pills styled their focus state with
:focus. That selector has lower specificity than the core Button's.components-button:focus:not(:active), which now draws a visible outset focus outline. As a result, the core outline overrode ours. The pill'soverflow: hiddenclipped that outline everywhere except where the accept and dismiss buttons meet, which left a stray mark next to the inset focus ring. The pills also kept showing their focus ring while pressed, unlike other buttons. This PR changes the accept and dismiss button selectors to&:focus:not(:active), the same selector used upstream.Use of AI Tools
AI assistance: Yes
Tool(s): Cursor
Model(s): Claude Opus 5.5
Used for: Generating the PR description.
Screenshots
Changelog Entry