Skip to content

Migrate skill evaluation scenarios from markdown to JSON format - #95

Open
NoumaanAhamed wants to merge 1 commit into
WordPress:trunkfrom
NoumaanAhamed:fix/eval-scenario-format-inconsistency
Open

NoumaanAhamed wants to merge 1 commit into
WordPress:trunkfrom
NoumaanAhamed:fix/eval-scenario-format-inconsistency

Conversation

@NoumaanAhamed

Copy link
Copy Markdown
Contributor

Resolves #94

Summary

  • shared/scripts/scaffold-skill.mjs now generates eval/scenarios/<skill-name>.json (matching the real name/skills/query/expected_behavior/success_criteria schema) instead of a markdown file that nothing else in the repo used
  • docs/authoring-guide.md and CONTRIBUTING.md updated to describe the JSON schema instead of "markdown files" — now consistent with eval/scenarios/README.md, which was already correct

Test plan

  • node eval/harness/run.mjs passes
  • node shared/scripts/scaffold-skill.mjs <name> "<desc>" generates a valid eval/scenarios/<name>.json matching the schema (verified locally, then removed as a throwaway test)

@github-actions

github-actions Bot commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: NoumaanAhamed <mohamedahamed@git.wordpress.org>
Co-authored-by: justlevine <justlevine@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@NoumaanAhamed

Copy link
Copy Markdown
Contributor Author

Hey Team,

Can you have a look at this and couple of other PRs when you get time? Thanks!

cc: @mikeyarce @jonathanbossenger ( Saw that you've worked on previous PRs, hence tagged you :) )

@justlevine

Copy link
Copy Markdown
Contributor

Nothing inherently wrong here, but considering that we don't actually have anything in-repo to execute these evals yet, it's still speculative.

@bgrgicak
bgrgicak requested a review from a team September 22, 2026 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scaffolding tool and docs generate/describe the wrong eval scenario format

2 participants