Skip to content

Add CODEOWNERS and designate @WordPress/interactivity-api as the code owners of the wp-interactivity-api skill - #25

Merged
jeffpaul merged 7 commits into
WordPress:trunkfrom
luisherranz:copilot/add-codeowners-file
Oct 21, 2026
Merged

Add CODEOWNERS and designate @WordPress/interactivity-api as the code owners of the wp-interactivity-api skill#25
jeffpaul merged 7 commits into
WordPress:trunkfrom
luisherranz:copilot/add-codeowners-file

Conversation

@luisherranz

@luisherranz luisherranz commented Feb 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

What

Adds a .github/CODEOWNERS file.

It initially designates @WordPress/interactivity-api team as the code owners of the skills/wp-interactivity-api/ directory.

/skills/wp-interactivity-api/ @WordPress/interactivity-api

Why

The Interactivity API was authored and is actively maintained by the @WordPress/interactivity-api team. Assigning code ownership for that skill ensures:

  • @WordPress/interactivity-api is automatically added as a required reviewer on any PR that modifies files inside skills/wp-interactivity-api/.
  • Changes to the skill go through the person with the deepest domain knowledge, keeping the skill accurate and up-to-date as the API evolves.
  • Other skills in the repository are unaffected — ownership is intentionally scoped only to this single skill directory.

How

A single .github/CODEOWNERS file is created with one ownership rule scoped to /skills/wp-interactivity-api/. No other files or skills are touched.

Copilot AI and others added 4 commits February 25, 2026 13:25
Initial plan
f614d28
@luisherranz
Add CODEOWNERS file
a852e4a 
Co-authored-by: luisherranz <3305402+luisherranz@users.noreply.github.com>
@luisherranz
Update CODEOWNERS to only cover skills/wp-interactivity-api
a2b5b7b 
Co-authored-by: luisherranz <3305402+luisherranz@users.noreply.github.com>
@luisherranz
Change ownership from luisherranz to frontend-dx
3836660
@luisherranz luisherranz changed the title Add CODEOWNERS and designate @WordPress/frontend-dx as the code owners of the wp-interactivity-api skill Add CODEOWNERS and designate @WordPress/interactivity-api as the code owners of the wp-interactivity-api skill Feb 25, 2026
@luisherranz

luisherranz commented Feb 25, 2026

Copy link
Copy Markdown
Member Author

@WordPress/interactivity-api, just so you know, once this is merged you will receive pings every time there is a PR that modifies the Interactivity API skill 🙂

@luisherranz
luisherranz marked this pull request as ready for review February 25, 2026 13:59
@github-actions

github-actions Bot commented Feb 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @Copilot.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: Copilot.

Co-authored-by: luisherranz <luisherranz@git.wordpress.org>
Co-authored-by: bgrgicak <berislavgrgicak@git.wordpress.org>
Co-authored-by: jeffpaul <jeffpaul@git.wordpress.org>
Co-authored-by: karmatosed <karmatosed@git.wordpress.org>
Co-authored-by: fellyph <fellyph@git.wordpress.org>
Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org>
Co-authored-by: DAreRodz <darerodz@git.wordpress.org>
Co-authored-by: juanmaguitar <juanmaguitar@git.wordpress.org>
Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@karmatosed

karmatosed commented Jul 6, 2026

Copy link
Copy Markdown
Member

@fellyph can you confirm that those codeowners agreed to this before we progress?

@fellyph

fellyph commented Jul 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hey @karmatosed. I'm not part of the Interactivity API team, but the reference looks right with: https://github.com/orgs/WordPress/teams/interactivity-api. Should we do the same for the Playground team?

@luisherranz

luisherranz commented Jul 7, 2026

Copy link
Copy Markdown
Member Author

Pinging @juanmaguitar, @cbravobernal, @DAreRodz and @SantosGuillamot so they can give their consent.

@SantosGuillamot

SantosGuillamot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

I give my consent 🙂 Thank you!

@jeffpaul

jeffpaul commented Jul 7, 2026

Copy link
Copy Markdown
Member

Probably worth setting https://github.com/orgs/WordPress/teams/agent-skills-maintainers as reviewers across the board as well?

@DAreRodz

DAreRodz commented Jul 7, 2026

Copy link
Copy Markdown

I also give my consent!

@juanmaguitar

juanmaguitar commented Jul 7, 2026

Copy link
Copy Markdown

I also give my consent 👍

@karmatosed
karmatosed self-requested a review July 7, 2026 17:50
karmatosed
karmatosed approved these changes Jul 7, 2026
View reviewed changes

@karmatosed karmatosed left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on consent adding approval. But there was a note to add others also made in comments, this could be done in additional PRs though.

@luisherranz

luisherranz commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

Thanks @karmatosed!

It looks like we need another approval to be able to merge.

@bgrgicak

bgrgicak commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@copilot fix this error

 Error: Compatibility contract mismatch in skills/wp-patterns/SKILL.md (expected WP 7.0 + PHP 7.4.0+)
    at assert (file:///home/runner/work/agent-skills/agent-skills/eval/harness/run.mjs:53:25)
    at main (file:///home/runner/work/agent-skills/agent-skills/eval/harness/run.mjs:114:5)
    at file:///home/runner/work/agent-skills/agent-skills/eval/harness/run.mjs:132:1
    at ModuleJob.run (node:internal/modules/esm/module_job:325:25)
    at async ModuleLoader.import (node:internal/modules/esm/loader:606:24)
    at async asyncRunEntryPointWithESMLoader (node:internal/modules/run_main:117:5)

@cbravobernal

cbravobernal commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Giving my consent about 5 months later, sorry 😓

@bgrgicak
bgrgicak requested a review from a team September 22, 2026 05:44
@jeffpaul

jeffpaul commented Sep 22, 2026

Copy link
Copy Markdown
Member

FYI based on #25 (comment) I went ahead and had #108 created as related to the work here

@jeffpaul
jeffpaul merged commit eff3785 into WordPress:trunk Oct 21, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karmatosed karmatosed karmatosed approved these changes
@bgrgicak bgrgicak bgrgicak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@luisherranz @karmatosed @fellyph @SantosGuillamot @jeffpaul @DAreRodz @juanmaguitar @bgrgicak @cbravobernal