Repository navigation
Fix wp-performance: wp doctor check needs --all or check names - #114
Merged
bgrgicak merged 3 commits intoOct 5, 2026
Merged
Conversation
The bare `wp doctor check` exits with "Please specify one or more checks, or use --all." and runs nothing. Step 2 and the Verification section now use `--all` and show the named-check form for a perf-focused run. Relates to WordPress#113.
Replace the bare command with `--all`, the named perf checks and `--spotlight`, and note that one of `--all` or a check name is required. Relates to WordPress#113.
…int scenario The scenario expected the bare `wp doctor check`, which errors. It now expects `--all` or named checks. Relates to WordPress#113.
Contributor
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
bgrgicak
approved these changes
Oct 5, 2026
bgrgicak
left a comment
bgrgicak
left a comment
Contributor
There was a problem hiding this comment.
Thanks for working on this @maheshbohara!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
wp-performanceskill tells agents to runwp doctor checkwith no arguments as the first diagnostic step. That command runs no checks and exits with an error:The guard is in
src/Command.phpL120-L123 ofwp-cli/doctor-command, and it is present in every release tag back to v0.1.0. An agent following the skill hits the error at step 2 ("Fast wins").Fixes #113.
Changes
skills/wp-performance/SKILL.md: step 2 now useswp doctor check --all(with--spotlightas an option) and shows the named-check form for a perf-focused run. The Verification bullet uses--alltoo.skills/wp-performance/references/wp-cli-doctor.md: "Recommended usage" lists--all, the three perf-related checks by name, and--all --spotlight, and notes that one of--allor a check name is required.eval/scenarios/performance-profile-slow-endpoint.json: step 4 and the matching success criterion expect--allor named checks instead of the bare command.Testing
node shared/scripts/validate-skills.mjspasses.wp doctor check--all