Skip to content

Commit beaa495

Browse files
joedolsonjoedolson
committed
Administration: Fix alignment in upload plugin/theme buttons.
Following [61598], the upload button for plugins and themes could cover the file information in the file input for longer internationalized strings due to absolute positioning. Update layout to use remove absolute positioning while retaining the larger drop area. Props audrasjb, pratiknawkar94, huzaifaalmesbah, noruzzaman, presskopp, joedolson. Fixes #64832. Built from https://develop.svn.wordpress.org/trunk@62090 git-svn-id: http://core.svn.wordpress.org/trunk@61372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
1 parent b70b0c7 commit beaa495

File tree

5 files changed

+21
-37
lines changed

5 files changed

+21
-37
lines changed

‎wp-admin/css/themes-rtl.css‎

Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1137,24 +1137,23 @@ body.folded .theme-browser ~ .theme-overlay .theme-wrap {
11371137
.upload-theme .wp-upload-form,
11381138
.upload-plugin .wp-upload-form {
11391139
position: relative;
1140-
margin: 30px auto;
1140+
margin: 30px;
11411141
display: inline-flex;
11421142
justify-content: space-between;
11431143
align-items: center;
1144+
border: 1px solid #c3c4c7;
1145+
background: #f6f7f7;
11441146
}
11451147

11461148
.upload-theme .wp-upload-form input[type="file"],
11471149
.upload-plugin .wp-upload-form input[type="file"] {
1148-
background: #f6f7f7;
1149-
border: 1px solid #c3c4c7;
1150+
background: transparent;
11501151
margin: 0;
1151-
padding: 30px 30px 30px 128px;
1152+
padding: 30px 30px 30px 0;
11521153
}
11531154

1154-
.upload-plugin .wp-upload-form input[type=submit],
1155-
.upload-theme .wp-upload-form input[type=submit] {
1156-
position: absolute;
1157-
left: 30px;
1155+
.wp-upload-form input[type="submit"].button {
1156+
margin-left: 30px;
11581157
}
11591158

11601159
.upload-theme .install-help,
@@ -2072,19 +2071,12 @@ body.full-overlay-active {
20722071
.upload-plugin .wp-upload-form,
20732072
.upload-theme .wp-upload-form {
20742073
width: 100%;
2074+
box-sizing: border-box;
20752075
}
20762076

20772077
.upload-plugin .wp-upload-form input[type=file],
20782078
.upload-theme .wp-upload-form input[type=file] {
2079-
padding: 30px 30px 80px;
2079+
padding: 30px 30px 30px 0;
20802080
width: 100%;
20812081
}
2082-
2083-
:is(.upload-theme, .upload-plugin) .wp-upload-form input[type="submit"].button {
2084-
left: unset;
2085-
right: 50%;
2086-
transform: translateX(50%) !important;
2087-
top: calc( 1.4em + 42px ); /* Line height of control + gap + top padding. */
2088-
margin: 10px 0 0;
2089-
}
20902082
}

‎wp-admin/css/themes-rtl.min.css‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎wp-admin/css/themes.css‎

Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1136,24 +1136,23 @@ body.folded .theme-browser ~ .theme-overlay .theme-wrap {
11361136
.upload-theme .wp-upload-form,
11371137
.upload-plugin .wp-upload-form {
11381138
position: relative;
1139-
margin: 30px auto;
1139+
margin: 30px;
11401140
display: inline-flex;
11411141
justify-content: space-between;
11421142
align-items: center;
1143+
border: 1px solid #c3c4c7;
1144+
background: #f6f7f7;
11431145
}
11441146

11451147
.upload-theme .wp-upload-form input[type="file"],
11461148
.upload-plugin .wp-upload-form input[type="file"] {
1147-
background: #f6f7f7;
1148-
border: 1px solid #c3c4c7;
1149+
background: transparent;
11491150
margin: 0;
1150-
padding: 30px 128px 30px 30px;
1151+
padding: 30px 0 30px 30px;
11511152
}
11521153

1153-
.upload-plugin .wp-upload-form input[type=submit],
1154-
.upload-theme .wp-upload-form input[type=submit] {
1155-
position: absolute;
1156-
right: 30px;
1154+
.wp-upload-form input[type="submit"].button {
1155+
margin-right: 30px;
11571156
}
11581157

11591158
.upload-theme .install-help,
@@ -2071,19 +2070,12 @@ body.full-overlay-active {
20712070
.upload-plugin .wp-upload-form,
20722071
.upload-theme .wp-upload-form {
20732072
width: 100%;
2073+
box-sizing: border-box;
20742074
}
20752075

20762076
.upload-plugin .wp-upload-form input[type=file],
20772077
.upload-theme .wp-upload-form input[type=file] {
2078-
padding: 30px 30px 80px;
2078+
padding: 30px 0 30px 30px;
20792079
width: 100%;
20802080
}
2081-
2082-
:is(.upload-theme, .upload-plugin) .wp-upload-form input[type="submit"].button {
2083-
right: unset;
2084-
left: 50%;
2085-
transform: translateX(-50%) !important;
2086-
top: calc( 1.4em + 42px ); /* Line height of control + gap + top padding. */
2087-
margin: 10px 0 0;
2088-
}
20892081
}

‎wp-admin/css/themes.min.css‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎wp-includes/version.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
*
1717
* @global string $wp_version
1818
*/
19-
$wp_version = '7.0-beta6-62089';
19+
$wp_version = '7.0-beta6-62090';
2020

2121
/**
2222
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.

0 commit comments

Comments
 (0)