Skip to content

Commit b9a6287

Browse files
mcsfmcsf
committed
Toolbar: Fix display name live preview and "Howdy" color.
When the display name is changed on the profile page, correctly update the user menu in the admin bar: don't overwrite the "Edit Profile" item, do update the aria-label attribute, and of course update the rendered username. Add class `display-name` to the greeting wrapper to better preserve back-compat with custom admin color schemes that only target `#wp-admin-bar-user-info .display-name`. Follow-up to r64502 and its revert, r64504. Props fushar, tyxla. Fixes #66222. Built from https://develop.svn.wordpress.org/trunk@64519 git-svn-id: http://core.svn.wordpress.org/trunk@63669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
1 parent 3ec380d commit b9a6287

41 files changed

Lines changed: 50 additions & 89 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎wp-admin/css/colors/_admin.scss‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -521,13 +521,10 @@ ul#adminmenu > li.current > a.current::after {
521521
background-color: variables.$adminbar-avatar-frame;
522522
}
523523

524-
#wpadminbar #wp-admin-bar-user-info .howdy,
525524
#wpadminbar #wp-admin-bar-user-info .display-name {
526525
color: variables.$menu-text;
527526
}
528527

529-
#wpadminbar #wp-admin-bar-user-info a:hover .howdy,
530-
#wpadminbar #wp-admin-bar-user-info a:focus .howdy,
531528
#wpadminbar #wp-admin-bar-user-info a:hover .display-name,
532529
#wpadminbar #wp-admin-bar-user-info a:focus .display-name {
533530
color: variables.$menu-submenu-focus-text;

‎wp-admin/css/colors/blue/colors-rtl.css‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -618,13 +618,10 @@ ul#adminmenu > li.current > a.current::after {
618618
background-color: rgb(44.2384615385, 100.7653846154, 147.4615384615);
619619
}
620620

621-
#wpadminbar #wp-admin-bar-user-info .howdy,
622621
#wpadminbar #wp-admin-bar-user-info .display-name {
623622
color: #fff;
624623
}
625624

626-
#wpadminbar #wp-admin-bar-user-info a:hover .howdy,
627-
#wpadminbar #wp-admin-bar-user-info a:focus .howdy,
628625
#wpadminbar #wp-admin-bar-user-info a:hover .display-name,
629626
#wpadminbar #wp-admin-bar-user-info a:focus .display-name {
630627
color: #fff;

‎wp-admin/css/colors/blue/colors-rtl.min.css‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎wp-admin/css/colors/blue/colors.css‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -618,13 +618,10 @@ ul#adminmenu > li.current > a.current::after {
618618
background-color: rgb(44.2384615385, 100.7653846154, 147.4615384615);
619619
}
620620

621-
#wpadminbar #wp-admin-bar-user-info .howdy,
622621
#wpadminbar #wp-admin-bar-user-info .display-name {
623622
color: #fff;
624623
}
625624

626-
#wpadminbar #wp-admin-bar-user-info a:hover .howdy,
627-
#wpadminbar #wp-admin-bar-user-info a:focus .howdy,
628625
#wpadminbar #wp-admin-bar-user-info a:hover .display-name,
629626
#wpadminbar #wp-admin-bar-user-info a:focus .display-name {
630627
color: #fff;

‎wp-admin/css/colors/blue/colors.min.css‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎wp-admin/css/colors/coffee/colors-rtl.css‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -618,13 +618,10 @@ ul#adminmenu > li.current > a.current::after {
618618
background-color: rgb(113.0538461538, 93.3923076923, 78.6461538462);
619619
}
620620

621-
#wpadminbar #wp-admin-bar-user-info .howdy,
622621
#wpadminbar #wp-admin-bar-user-info .display-name {
623622
color: #fff;
624623
}
625624

626-
#wpadminbar #wp-admin-bar-user-info a:hover .howdy,
627-
#wpadminbar #wp-admin-bar-user-info a:focus .howdy,
628625
#wpadminbar #wp-admin-bar-user-info a:hover .display-name,
629626
#wpadminbar #wp-admin-bar-user-info a:focus .display-name {
630627
color: #fff;

‎wp-admin/css/colors/coffee/colors-rtl.min.css‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎wp-admin/css/colors/coffee/colors.css‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -618,13 +618,10 @@ ul#adminmenu > li.current > a.current::after {
618618
background-color: rgb(113.0538461538, 93.3923076923, 78.6461538462);
619619
}
620620

621-
#wpadminbar #wp-admin-bar-user-info .howdy,
622621
#wpadminbar #wp-admin-bar-user-info .display-name {
623622
color: #fff;
624623
}
625624

626-
#wpadminbar #wp-admin-bar-user-info a:hover .howdy,
627-
#wpadminbar #wp-admin-bar-user-info a:focus .howdy,
628625
#wpadminbar #wp-admin-bar-user-info a:hover .display-name,
629626
#wpadminbar #wp-admin-bar-user-info a:focus .display-name {
630627
color: #fff;

‎wp-admin/css/colors/coffee/colors.min.css‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎wp-admin/css/colors/ectoplasm/colors-rtl.css‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -618,13 +618,10 @@ ul#adminmenu > li.current > a.current::after {
618618
background-color: rgb(90.9346153846, 62.6711538462, 129.0288461538);
619619
}
620620

621-
#wpadminbar #wp-admin-bar-user-info .howdy,
622621
#wpadminbar #wp-admin-bar-user-info .display-name {
623622
color: #fff;
624623
}
625624

626-
#wpadminbar #wp-admin-bar-user-info a:hover .howdy,
627-
#wpadminbar #wp-admin-bar-user-info a:focus .howdy,
628625
#wpadminbar #wp-admin-bar-user-info a:hover .display-name,
629626
#wpadminbar #wp-admin-bar-user-info a:focus .display-name {
630627
color: #fff;

0 commit comments

Comments
 (0)