Repository navigation
Dashboard: joined-to-date card and growth chart now count the same students - #303
Merged
peiraisotta merged 1 commit intoNov 9, 2026
Conversation
…chart The growth chart kept its own allowlist of "joined" statuses and missed the newer tracks (Intro to Contribution, Developer, Designer, Foundations), so it read 893 against the card's 1034. Both now use one has_joined() predicate: every status except Interested, Not moving forward and SPAM. Paused and Fail count as joined in both. The build warns if the two totals ever differ by more than the pre-launch or future-dated records the chart leaves out. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SL7xkuA9nu4T8BeMMRX6Av
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The growth chart used its own status allowlist and missed the newer tracks (Intro to Contribution, Developer, Designer, Foundations), reading 893 against the card's 1034. Both now share one
has_joined()predicate, Paused and Fail count as joined in both, and the build warns if the totals ever differ beyond pre-launch or future-dated records. Tests added.