Requests: remove duplicate match_domain() method#617
Merged
schlessera merged 1 commit intodevelopfrom Nov 15, 2021
Merged
Conversation
This method was "moved" to the `SSL` class in 2013 and is publicly accessible in that class. The method is never called from within the Requests code base and shouldn't exist.
|
this method will work. |
Member
Author
@rashidkalwar786 Sorry, it is not clear to me what you mean to say with your feedback. |
schlessera
approved these changes
Nov 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method was "moved" to the
SSLclass in 2013 via 0c2fe6e and is publicly accessible in that class. The method within theRequestsclass is never called from within the Requests code base and shouldn't exist.