Fix reports by PHPStan#608
Merged
jrfnl merged 10 commits intoWordPress:developfrom Nov 13, 2021
szepeviktor:patch-1
Merged
Conversation
Contributor
Author
|
Please consider using @phpstan |
jrfnl
requested changes
Nov 12, 2021
Member
jrfnl
left a comment
jrfnl
left a comment
There was a problem hiding this comment.
Thanks @szepeviktor. Happy to accept these changes once my remarks are addressed.
Adding PHPStan is something for "maybe later" as the current focus is on getting version 2.0.0 released without further delay.
jrfnl
reviewed
Nov 13, 2021
Co-authored-by: Juliette <663378+jrfnl@users.noreply.github.com>
Contributor
Author
|
@jrfnl I leave all this up to you. Please close it or merge it. |
jrfnl
approved these changes
Nov 13, 2021
Member
jrfnl
left a comment
jrfnl
left a comment
There was a problem hiding this comment.
Thanks @szepeviktor ! The current changes as they are LGTM.
Contributor
Author
|
You're welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix things while running
vendor/bin/phpstan analyze src/ -l 3Pull Request Type
This is a: