Merged
Conversation
16 tasks
jrfnl
force-pushed
the
feature/auth-basic-improve-tests
branch
from
37aafac to
a8b2ec0
Compare
* Move the (duplicate) test skipping code to a test helper function with a descriptive name. * Use a dynamic function call to call the `test()` method instead of using `call_user_func()`. * Make the skip message slightly more descriptive.
* Remove assumptions from the tests in favour of explicitly verifying those assumptions via assertions. * Add `$message` parameter to each assertion as there are multiple assertions in each test.
* Use a dataprovider with named data sets to test that the exception is thrown in all situations in which it should be thrown. * Rename the test method to a more descriptive name for the fact that multiple situations are now being tested. * Add documentation to the test method.
... and add a class level `@covers` tag.
jrfnl
force-pushed
the
feature/auth-basic-improve-tests
branch
from
a8b2ec0 to
dab6295
Compare
schlessera
approved these changes
Oct 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auth\BasicTest: move test skipping to helper method
test()method instead of usingcall_user_func().Auth\BasicTest: stabilize the tests
$messageparameter to each assertion as there are multiple assertions in each test.Auth\BasicTest: improve test for invalid argument count exception
Auth\BasicTest: improve docblocks
... and add a class level
@coverstag.Related to #497