Merged
Conversation
... grouping tests related to array access together.
* Merge two tests doing the exact same thing, into one test using a data provider with named data sets. * Add docblock documentation to the test and the data provider.
* Add `$message` parameter to each assertion as there are multiple assertions in the test. * Make the exception more descriptive (not that I expect it to ever be thrown). * Add a docblock to the test. * Remove the `@depends` annotation which doesn't make any sense here.
The `Header::getIterator()` method uses the `Header::flatten()` method, but there was no test safeguarding this functionality against regressions. Fixed now by adding an additional check to the `HeadersTest::testIteration()` method.
.. for functionality previously not covered by a test.
... which was, so far, not covered by tests yet.
schlessera
approved these changes
Sep 23, 2021
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HeadersTest: rearrange the method order in the test class
... grouping tests related to array access together.
HeadersTest: rename a test to be more descriptive
HeadersTest: refactor array access tests
HeadersTest::testIteration(): various minor tweaks
$messageparameter to each assertion as there are multiple assertions in the test.@dependsannotation which doesn't make any sense here.HeadersTest::testIteration(): safeguard the flattening
The
Header::getIterator()method uses theHeader::flatten()method, but there was no test safeguarding this functionality against regressions.Fixed now by adding an additional check to the
HeadersTest::testIteration()method.HeadersTest: add extra test for offsetGet()
.. for functionality previously not covered by a test.
HeadersTest: add test for getValues()
... which was, so far, not covered by tests yet.
HeadersTest: add docblocks to the rest of the tests
HeadersTest: add @Covers tags
Related to #497