Requests: set default transports as a constant#541
Merged
schlessera merged 1 commit intodevelopfrom Sep 17, 2021
Merged
Conversation
schlessera
requested changes
Sep 17, 2021
The default supported transports do not change during the request, so should be a constant and as the minimum PHP version is now PHP 5.6, we can use constant arrays. I've elected to set this array with the same value for key and value to allow using `isset()` against the array. I've also adjusted the `Requests::add_transport()` method to set the key as well, which automatically allows us to get rid of the expensive and unnecessary `array_merge()`. The list of supported constants was also used in multiple (duplicate) data providers in the tests. This duplication has been removed by adding this data provider to the base `TestCase`, making it available to all tests. The data provider in the base `TestCase`: * Makes use of the new constant to always provide the list of all supported transport classes. * Has been set up to provide named data sets to allow for more descriptive tests when running the tests using `--testdox` and for easier debugging.
jrfnl
force-pushed
the
feature/513-6-unify-dataprovider-for-tests
branch
from
abe982d to
e21107c
Compare
schlessera
approved these changes
Sep 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default supported transports do not change during the request, so should be a constant and as the minimum PHP version is now PHP 5.6, we can use constant arrays.
I've elected to set this array with the same value for key and value to allow using
isset()against the array.I've also adjusted the
Requests::add_transport()method to set the key as well, which automatically allows us to get rid of the expensive and unnecessaryarray_merge().The list of supported constants was also used in multiple (duplicate) data providers in the tests.
This duplication has been removed by adding this data provider to the base
TestCase, making it available to all tests.The data provider in the base
TestCase:--testdoxand for easier debugging.Part of a PR series to address #513