Requests: set default certificate path as a constant#535
Merged
schlessera merged 1 commit intodevelopfrom Sep 17, 2021
Merged
Conversation
This value does not change during the request, so should be a constant and as the minimum PHP version is now PHP 5.6, we can use constant scalar expressions in constants, so don't have to worry about the concatenation. Includes moving this static file to a separate directory, so the `src` directory only contains code, not assets, like the certificates file and updating references to the file location elsewhere in the code.
schlessera
approved these changes
Sep 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
This is a:
Context
Removing "magic numbers".
Part of a PR series to address #513
Detailed Description
This value does not change during the request, so should be a constant and as the minimum PHP version is now PHP 5.6, we can use constant scalar expressions in constants, so don't have to worry about the concatenation.
Includes moving this static file to a separate directory, so the
srcdirectory only contains code, not assets, like the certificates file and updating references to the file location elsewhere in the code.