Skip to content

Patch to fix minor C++ and Linux issues #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ash-Olorenshaw wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −6
Open

Patch to fix minor C++ and Linux issues #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libwebview-nodejs/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions libwebview-nodejs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@
"CMakeLists.txt"
],
"scripts": {
"install": "cmake-js rebuild",
"install": "cmake-js rebuild --CDWEBVIEW_WEBKITGTK_API=\"$WEBVIEW_WEBKITGTK_API\"",
"start": "node test.js",
"build": "cmake-js build",
"rebuild": "cmake-js rebuild",
"build": "cmake-js build --CDWEBVIEW_WEBKITGTK_API=\"$WEBVIEW_WEBKITGTK_API\"",
"rebuild": "cmake-js rebuild --CDWEBVIEW_WEBKITGTK_API=\"$WEBVIEW_WEBKITGTK_API\"",
"test": "echo \"Error: no test specified\" && exit 1"
},
"author": "",
Expand Down
3 changes: 2 additions & 1 deletion libwebview-nodejs/src/webview_wrap.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1974,6 +1974,7 @@ Napi::Value _wrap_webview_bind(const Napi::CallbackInfo &info) {
char *buf2 = 0 ;
int alloc2 = 0 ;
int res4 ;
BindArg* cb;

if(static_cast<int>(info.Length()) < 4 || static_cast<int>(info.Length()) > 4) {
SWIG_Error(SWIG_ERROR, "Illegal number of arguments for _wrap_webview_bind.");
Expand Down Expand Up @@ -2005,7 +2006,7 @@ Napi::Value _wrap_webview_bind(const Napi::CallbackInfo &info) {
int res = SWIG_ConvertFunctionPtr(info[2], (void**)(&arg3), SWIGTYPE_p_f_p_q_const__char_p_q_const__char_p_void__void);
SWIG_exception_fail(SWIG_ArgError(res), "in method '" "webview_bind" "', argument " "3"" of type '" "void (*)(char const *,char const *,void *)""'");
}
BindArg* cb = new BindArg {
cb = new BindArg {
Napi::FunctionReference(Napi::Persistent(info[2].As<Napi::Function>())),
env
};
Expand Down