Patch to fix minor C++ and Linux issues#35
Open
Ash-Olorenshaw wants to merge 1 commit into
Open
Conversation
- Allow passing 'WEBVIEW_WEBKITGTK_API' to webview so that you can specify your WebKit version for building for Linux (see: 'https://github.com/webview/webview#linux-specific-options') - Fix issue with newer C++ versions that breaks build due to a var being initialised before the 'exit' label Signed-off-by: Ash-Olorenshaw <asholorenshaw@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basic idea of this PR is just to fix a couple issues that arise due to using newer versions of Webview.
The first thing is to allow passing
WEBVIEW_WEBKITGTK_APIto webview so that you can specify your WebKit version for building for Linux (see: 'https://github.com/webview/webview#linux-specific-options'). The big usecase for this is that by defaultwebviewwill be built againstwebkit2gtk4.0which doesn't exist in the Fedora Linux repos anymore (and version4.1is the recommended version now anyway) so the build will break. You can now install this package with the environment varWEBVIEW_WEBKITGTK_APIwhich gets passed to CMake and then you can specify the version you want installed, e.g.WEBVIEW_WEBKITGTK_API="6.0" npm install webview-nodejsI am completely welcome to different ways we could fix this, this was just the only thing I could think of besides incrementing the webview version manually in the
package.json.This PR also fixes a minor issue with newer C++ versions that breaks build due to a var being initialised before the 'exit' label in
webview_wrap.cxx.EDIT: fixed some grammar