Don't use HTML-encoded URLs for API calls. #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'{{ query_string }}' is an HTML-escaped string (e.g. '&' instead of
'&'). This means that, in an URL like:
/graph/?project=&startdate=2021-01-14&search_type=or&enddate=&user=&query=1Lib1Ref%2C+1lib1refCEE%2C+1bib1ref
'{{ query_string }}' is:
"project=&startdate=2021-01-14&search_type=or&enddate=&user=&query=1Lib1Ref%2C+1lib1refCEE%2C+1bib1ref"
Note how every parameter after the first ("project") is preceded by
'&'. When this is used to construct an API query in the graphs page,
this causes every parameter except for the first to be ignored.
Member
|
Good catch! Got my local environment set up again and tested this with the date filter, and it seems to work as intended where it previously didn't! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{{ query_string }}is an HTML-escaped string (e.g.&instead of&). This means that, in an URL like:/graph/?project=&startdate=2021-01-14&search_type=or&enddate=&user=&query=1Lib1Ref%2C+1lib1refCEE%2C+1bib1ref{{ query_string }}is:project=&startdate=2021-01-14&search_type=or&enddate=&user=&query=1Lib1Ref%2C+1lib1refCEE%2C+1bib1refNote how every parameter after the first ("project") is preceded by
&. When this is used to construct an API query in the graphs page, this causes every parameter except for the first to be ignored, because it has a different name than what the server expects.