update InterceptorSamples

WeihanLi · WeihanLi · commit 6401d0d033d7 · 2023-12-10T14:20:34.000+08:00
diff --git a/InterceptorSamples/InterceptorGenerators/CreateScopeActivityGenerator.cs b/InterceptorSamples/InterceptorGenerators/CreateScopeActivityGenerator.cs
@@ -14,18 +14,11 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
         var methodCalls = context.SyntaxProvider.CreateSyntaxProvider(
             predicate: static (node, _) =>
             {
-                if (node is
-                    InvocationExpressionSyntax
+                if (node is InvocationExpressionSyntax
                     {
                         Expression: MemberAccessExpressionSyntax
                         {
-                            Name:
-                            {
-                                Identifier:
-                                {
-                                    ValueText: "CreateScope" or "CreateAsyncScope"
-                                }
-                            }
+                            Name.Identifier.ValueText: "CreateScope" or "CreateAsyncScope"
                         }
                     })
                 {
@@ -67,9 +60,12 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
                     var interceptorCode =
                         (invocationGroup.Key.ContainingTypeName, invocationGroup.Key.MethodName) switch
                         {
-                            ("Microsoft.Extensions.DependencyInjection.IServiceScopeFactory", "CreateScope") => ScopeActivityGeneratedSource.ServiceScopeFactoryCreateScopeInterceptorCode,
-                            ("Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions", "CreateScope") => ScopeActivityGeneratedSource.ServiceProviderCreateScopeInterceptorCode,
-                            ("Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions", "CreateAsyncScope") => ScopeActivityGeneratedSource.ServiceProviderCreateScopeAsyncInterceptorCode,
+                            ("Microsoft.Extensions.DependencyInjection.IServiceScopeFactory", "CreateScope") 
+                                => ScopeActivityGeneratedSource.ServiceScopeFactoryCreateScopeInterceptorCode,
+                            ("Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions", "CreateScope") 
+                                => ScopeActivityGeneratedSource.ServiceProviderCreateScopeInterceptorCode,
+                            ("Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions", "CreateAsyncScope") 
+                                => ScopeActivityGeneratedSource.ServiceProviderCreateScopeAsyncInterceptorCode,
                             _ => throw new ArgumentOutOfRangeException($"{invocationGroup.Key.MethodName}")
                         };
                     stringBuilder.AppendLine(interceptorCode);
diff --git a/InterceptorSamples/InterceptorGenerators/InterceptInvocation.cs b/InterceptorSamples/InterceptorGenerators/InterceptInvocation.cs
@@ -7,20 +7,14 @@ namespace InterceptorGenerators;
 internal sealed class InterceptInvocation
 {
     private readonly MemberAccessExpressionSyntax _memberAccessExpressionSyntax;
-
     private readonly IInvocationOperation _invocationOperation;
 
     public InterceptInvocation(IInvocationOperation invocationOperation)
     {
         _invocationOperation = invocationOperation;
-        // The invocation expression consists of two properties:
-        // - Expression: which is a `MemberAccessExpressionSyntax` that represents the method being invoked.
-        // - ArgumentList: the list of arguments being invoked.
-        // Here, we resolve the `MemberAccessExpressionSyntax` to get the location of the method being invoked.
         _memberAccessExpressionSyntax =
             (MemberAccessExpressionSyntax)((InvocationExpressionSyntax)_invocationOperation.Syntax)
             .Expression;
-        // `MemberAccessExpressionSyntax`.Name: the name of the member being accessed
         MethodName = _memberAccessExpressionSyntax.Name.Identifier.Text;
         AssemblyName = _invocationOperation.TargetMethod.ContainingAssembly.MetadataName;
         ContainingNamespace = _invocationOperation.TargetMethod.ContainingNamespace.GetFullNamespace();
@@ -48,6 +42,7 @@ public InterceptInvocation(IInvocationOperation invocationOperation)
 
     private (string filePath, int line, int column) GetLocation()
     {
+        // https://github.com/dotnet/aspnetcore/blob/3f1acb59718cadf111a0a796681e3d3509bb3381/src/Http/Http.Extensions/gen/StaticRouteHandlerModel/Endpoint.cs#L143
         // The `MemberAccessExpressionSyntax` in turn includes three properties:
         // - Expression: the expression that is being accessed.
         // - OperatorToken: the operator token, typically the dot separate.
