Skip to content

Possible optimizations #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
WebReflection merged 1 commit into from
Apr 4, 2020
Merged

Possible optimizations #4

WebReflection merged 1 commit into from
Apr 4, 2020

Conversation

@WebReflection
Copy link
Owner

@WebReflection WebReflection commented Apr 4, 2020

There are at least two possible optimizations to do:

  • avoid break (reduce size)
  • avoid checking !map all over and just use an empty map

The first point is trivial, the second is clean but not obvious in terms of performance.

Keeping this open until I find a way to benchmark this against master.

@WebReflection
Copy link
Owner Author

WebReflection commented Apr 4, 2020

on a second thought, creating a new Map when it's not needed doesn't seem like a possible improvement, so I'm happy with this.

@WebReflection WebReflection merged commit 0e29e3c into master Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@WebReflection