Skip to content

ariaErrorMessageElements should be ariaErrorMessageElement#7989

Closed
rniwa wants to merge 1 commit intoWebKit:mainfrom
rniwa:fix249752
Closed

ariaErrorMessageElements should be ariaErrorMessageElement#7989
rniwa wants to merge 1 commit intoWebKit:mainfrom
rniwa:fix249752

Conversation

@rniwa
Copy link
Copy Markdown
Member

@rniwa rniwa commented Dec 22, 2022 •
edited by webkit-early-warning-system
Loading

14a11aa

ariaErrorMessageElements should be ariaErrorMessageElement
https://bugs.webkit.org/show_bug.cgi?id=249752

Reviewed by NOBODY (OOPS!).

Replace ariaErrorMessageElements with ariaErrorMessageElement per spec:
https://w3c.github.io/aria/#accessibilityroleandproperties-correspondence

* LayoutTests/accessibility/ARIA-reflection-expected.txt:
* LayoutTests/accessibility/ARIA-reflection.html:
* LayoutTests/accessibility/custom-elements/describedby-expected.txt:
* LayoutTests/accessibility/custom-elements/describedby-shadow-expected.txt:
* LayoutTests/accessibility/custom-elements/describedby-shadow.html:
* LayoutTests/accessibility/custom-elements/describedby.html:
* LayoutTests/accessibility/element-reflection-ariaerrormessage-expected.txt:
* LayoutTests/accessibility/element-reflection-ariaerrormessage.html:
* LayoutTests/fast/custom-elements/reactions-for-aria-element-attributes-expected.txt:
* LayoutTests/fast/custom-elements/reactions-for-aria-element-attributes.html:
* LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/ElementInternals-accessibility-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/dom/aria-element-reflection-expected.txt:
* Source/WebCore/accessibility/AriaAttributes.idl:
* Source/WebCore/bindings/js/JSElementCustom.cpp:
(WebCore::JSElement::ariaErrorMessageElements const): Deleted.
* Source/WebCore/bindings/js/JSElementInternalsCustom.cpp:
(WebCore::JSElementInternals::ariaErrorMessageElements const): Deleted.
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::isElementReflectionAttribute):
(WebCore::Element::isElementsArrayReflectionAttribute):
* Source/WebCore/dom/ElementInternals.idl:

14a11aa

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@rniwa rniwa requested a review from cdumez as a code owner December 22, 2022 00:32
@rniwa rniwa self-assigned this Dec 22, 2022
@rniwa rniwa added the Accessibility For bugs related to accessibility. label Dec 22, 2022
@rniwa rniwa requested review from fleizach and mrego December 22, 2022 00:32
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Dec 22, 2022 •
edited
Loading

EWS run on previous version of this PR (hash cd579f6)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ❌ 🧪 gtk-wk2
  🧪 api-ios ❌ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 tv ❌ 🧪 mac-wk2
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

cdumez
cdumez approved these changes Dec 22, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@cdumez cdumez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 22, 2022
@rniwa
ariaErrorMessageElements should be ariaErrorMessageElement
14a11aa 
https://bugs.webkit.org/show_bug.cgi?id=249752

Reviewed by NOBODY (OOPS!).

Replace ariaErrorMessageElements with ariaErrorMessageElement per spec:
https://w3c.github.io/aria/#accessibilityroleandproperties-correspondence

* LayoutTests/accessibility/ARIA-reflection-expected.txt:
* LayoutTests/accessibility/ARIA-reflection.html:
* LayoutTests/accessibility/custom-elements/describedby-expected.txt:
* LayoutTests/accessibility/custom-elements/describedby-shadow-expected.txt:
* LayoutTests/accessibility/custom-elements/describedby-shadow.html:
* LayoutTests/accessibility/custom-elements/describedby.html:
* LayoutTests/accessibility/element-reflection-ariaerrormessage-expected.txt:
* LayoutTests/accessibility/element-reflection-ariaerrormessage.html:
* LayoutTests/fast/custom-elements/reactions-for-aria-element-attributes-expected.txt:
* LayoutTests/fast/custom-elements/reactions-for-aria-element-attributes.html:
* LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/ElementInternals-accessibility-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/dom/aria-element-reflection-expected.txt:
* Source/WebCore/accessibility/AriaAttributes.idl:
* Source/WebCore/bindings/js/JSElementCustom.cpp:
(WebCore::JSElement::ariaErrorMessageElements const): Deleted.
* Source/WebCore/bindings/js/JSElementInternalsCustom.cpp:
(WebCore::JSElementInternals::ariaErrorMessageElements const): Deleted.
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::isElementReflectionAttribute):
(WebCore::Element::isElementsArrayReflectionAttribute):
* Source/WebCore/dom/ElementInternals.idl:
@rniwa rniwa removed the merging-blocked Applied to prevent a change from being merged label Dec 22, 2022
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Dec 22, 2022 •
edited
Loading

EWS run on current version of this PR (hash 14a11aa)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@mrego
Copy link
Copy Markdown
Member

mrego commented Dec 22, 2022

Note that WebKit allows to reference more than one element in aria-errormessage property: https://github.com/WebKit/WebKit/blob/main/LayoutTests/accessibility/mac/aria-errormessage.html

There was an ARIA issue and PR about this, but it seems things haven't landed on the spec yet. Maybe @cookiecrook can provide some feedback on this topic.

@rniwa
Copy link
Copy Markdown
Member Author

rniwa commented Dec 22, 2022

I'm fine with either outcome but clearly we want to be interoperable across browsers. WebKit shipping one off implementation for list isn't going to work.

@mrego
Copy link
Copy Markdown
Member

mrego commented Dec 22, 2022

I'm fine with either outcome but clearly we want to be interoperable across browsers. WebKit shipping one off implementation for list isn't going to work.

Yeah sure, as the ARIA PR was approved I thought it'd have been merged, but it looks it hasn't yet.

I'm fine with this change here, but the problem is that in WebKit you can do aria-errormessage="el1 el2 el3" in HTML, and then what happens when you call myelement.ariaErrorMessageElement? I guess only 1 element?

@cookiecrook
Copy link
Copy Markdown
Contributor

cookiecrook commented Jan 10, 2023

I think this WebKit PR and Issue should be closed as NTBF/WONTFIX. The ARIA PR hasn't merged yet because Co-Chair @spectranaut wants a WPT test, but that won't change the implementation. Multiple content attribute IDREFS in aria-errormessage will be reflected as plural ariaErrorMessageElements.

@rniwa
Copy link
Copy Markdown
Member Author

rniwa commented Jan 10, 2023

I think this WebKit PR and Issue should be closed as NTBF/WONTFIX. The ARIA PR hasn't merged yet because Co-Chair @spectranaut wants a WPT test, but that won't change the implementation. Multiple content attribute IDREFS in aria-errormessage will be reflected as plural ariaErrorMessageElements.

Sounds like we should update WPT then.

@rniwa rniwa closed this Jan 11, 2023
@rniwa rniwa deleted the fix249752 branch January 11, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdumez cdumez cdumez approved these changes

@mrego mrego Awaiting requested review from mrego

@fleizach fleizach Awaiting requested review from fleizach fleizach is a code owner

Assignees

@rniwa rniwa

Labels

Accessibility For bugs related to accessibility.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rniwa @webkit-early-warning-system @mrego @cookiecrook @cdumez @webkit-ews-buildbot