Skip to content

Implement IDL changes for hidden=until-found#43043

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
nt1m:eng/Make-IDL-changes-for-hidden-until-found
Mar 26, 2025
Merged

Implement IDL changes for hidden=until-found#43043
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
nt1m:eng/Make-IDL-changes-for-hidden-until-found

Conversation

@nt1m
Copy link
Copy Markdown
Member

@nt1m nt1m commented Mar 26, 2025 •
edited by webkit-early-warning-system
Loading

03b9c3b

Implement IDL changes for `hidden=until-found`
https://bugs.webkit.org/show_bug.cgi?id=290369
rdar://147940452

Reviewed by Anne van Kesteren and Darin Adler.

Implement:
- Add preference
- IDL changes specified at: https://html.spec.whatwg.org/#htmlelement
- DOM getter/setter algorithms specified at: https://html.spec.whatwg.org/#dom-hidden

* LayoutTests/imported/w3c/web-platform-tests/html/editing/the-hidden-attribute/hidden-idl-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/editing/the-hidden-attribute/hidden-until-found-idl-expected.txt:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/html/HTMLElement.cpp:
(WebCore::HTMLElement::hidden const):
(WebCore::HTMLElement::setHidden):
* Source/WebCore/html/HTMLElement.h:
* Source/WebCore/html/HTMLElement.idl:

Canonical link: https://commits.webkit.org/292735@main

d6f11f8

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc   🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
  🛠 🧪 merge ✅ 🧪 vision-wk2   🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ❌ 🛠 mac-safer-cpp ✅ 🛠 jsc-armv7
  🛠 tv-sim   🧪 jsc-armv7-tests
✅ 🛠 watch
✅ 🛠 watch-sim

@nt1m nt1m requested review from cdumez and rniwa as code owners March 26, 2025 17:18
@nt1m nt1m self-assigned this Mar 26, 2025
@nt1m nt1m added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label Mar 26, 2025
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Mar 26, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 784316b)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc   🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ⏳ 🧪 jsc-armv7-tests
✅ 🛠 watch
✅ 🛠 watch-sim

@nt1m nt1m requested review from annevk, darinadler and weinig March 26, 2025 17:19
annevk
annevk approved these changes Mar 26, 2025
View reviewed changes
Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Outdated
Copy link
Copy Markdown
Contributor

@annevk annevk Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we already support this? This is only hidden getter/setter support for it right?

Assuming we already support this feature I'd enable this by default as this is a trivial change to the getter/setter. But we should change the name here then to make it more clear this is solely about the getter/setter.

Copy link
Copy Markdown
Member Author

@nt1m nt1m Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we do? There's some work around the reveal algorithm, which removes the hidden attribute when find-in-page reaches it, and emits a beforematch event.

@nt1m nt1m force-pushed the eng/Make-IDL-changes-for-hidden-until-found branch from 784316b to a746257 Compare March 26, 2025 21:43
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Mar 26, 2025 •
edited
Loading

EWS run on previous version of this PR (hash a746257)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim   🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2 ⏳ 🧪 api-mac   🧪 api-wpe
⏳ 🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-cairo
  🛠 🧪 jsc ⏳ 🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
  🛠 🧪 jsc-arm64   🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
  🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
  🛠 🧪 merge ⏳ 🧪 vision-wk2 ⏳ 🧪 mac-intel-wk2   🛠 playstation
  🛠 tv   🛠 mac-safer-cpp ✅ 🛠 jsc-armv7
  🛠 tv-sim ⏳ 🧪 jsc-armv7-tests
  🛠 watch
  🛠 watch-sim

@nt1m nt1m added the merge-queue Applied to send a pull request to merge-queue label Mar 26, 2025
darinadler
darinadler approved these changes Mar 26, 2025
View reviewed changes
@nt1m nt1m removed the merge-queue Applied to send a pull request to merge-queue label Mar 26, 2025
@nt1m nt1m force-pushed the eng/Make-IDL-changes-for-hidden-until-found branch from a746257 to d6f11f8 Compare March 26, 2025 21:48
@nt1m nt1m added the merge-queue Applied to send a pull request to merge-queue label Mar 26, 2025
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Mar 26, 2025 •
edited
Loading

EWS run on current version of this PR (hash d6f11f8)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc   🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
  🛠 🧪 merge ✅ 🧪 vision-wk2   🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ❌ 🛠 mac-safer-cpp ✅ 🛠 jsc-armv7
  🛠 tv-sim   🧪 jsc-armv7-tests
✅ 🛠 watch
✅ 🛠 watch-sim

@nt1m nt1m added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merge-queue Applied to send a pull request to merge-queue labels Mar 26, 2025
@nt1m
Implement IDL changes for hidden=until-found
03b9c3b 
https://bugs.webkit.org/show_bug.cgi?id=290369
rdar://147940452

Reviewed by Anne van Kesteren and Darin Adler.

Implement:
- Add preference
- IDL changes specified at: https://html.spec.whatwg.org/#htmlelement
- DOM getter/setter algorithms specified at: https://html.spec.whatwg.org/#dom-hidden

* LayoutTests/imported/w3c/web-platform-tests/html/editing/the-hidden-attribute/hidden-idl-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/editing/the-hidden-attribute/hidden-until-found-idl-expected.txt:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/html/HTMLElement.cpp:
(WebCore::HTMLElement::hidden const):
(WebCore::HTMLElement::setHidden):
* Source/WebCore/html/HTMLElement.h:
* Source/WebCore/html/HTMLElement.idl:

Canonical link: https://commits.webkit.org/292735@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Make-IDL-changes-for-hidden-until-found branch from d6f11f8 to 03b9c3b Compare March 26, 2025 23:56
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

webkit-commit-queue commented Mar 26, 2025

Committed 292735@main (03b9c3b): https://commits.webkit.org/292735@main

Reviewed commits have been landed. Closing PR #43043 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 03b9c3b into WebKit:main Mar 26, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 26, 2025
@saschanaz saschanaz mentioned this pull request Nov 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@annevk annevk annevk approved these changes

@darinadler darinadler darinadler approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@rniwa rniwa Awaiting requested review from rniwa rniwa is a code owner

@weinig weinig Awaiting requested review from weinig

Assignees

@nt1m nt1m

Labels

DOM For bugs specific to XML/HTML DOM elements (including parsing).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nt1m @webkit-early-warning-system @webkit-commit-queue @annevk @darinadler