REGRESSION(252070@main): [ iOS16 Debug ] Updates to WebCore::RenderLayerBacking::updateGeometry cause testing to exit early and not complete#2484
Conversation
…yerBacking::updateGeometry cause testing to exit early and not complete https://bugs.webkit.org/show_bug.cgi?id=242832 Reviewed by NOBODY (OOPS!). Partial revert of 252070@main to fix the changes that updateGeometry broke on iOS16 Debug beta. * Source/WebCore/rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::~RenderLayerBacking): (WebCore::RenderLayerBacking::destroyGraphicsLayers): (WebCore::RenderLayerBacking::updateConfiguration): (WebCore::RenderLayerBacking::updateGeometry): (WebCore::RenderLayerBacking::updateChildClippingStrategy): (WebCore::RenderLayerBacking::updatePaintingPhases): (WebCore::RenderLayerBacking::setContentsNeedDisplay): (WebCore::RenderLayerBacking::setContentsNeedDisplayInRect): (WebCore::RenderLayerBacking::paintContents): (WebCore::RenderLayerBacking::backingStoreMemoryEstimate const): * Source/WebCore/rendering/RenderLayerBacking.h:
robert-jenner
added
New Bugs
Contributor
Author
|
Going to let this run all checks before landing. |
webkit-early-warning-system
added
the
merging-blocked
fujii
reviewed
Jul 16, 2022
| void RenderLayerBacking::updateChildClippingStrategy(bool needsDescendantsClippingLayer) | ||
| { | ||
| auto needsClipMaskLayer = [&] { | ||
| return needsDescendantsClippingLayer && is<RenderBox>(renderer()) && (renderer().style().hasBorderRadius() || renderer().style().clipPath()); |
Contributor
There was a problem hiding this comment.
This code has a problem. This will create an unnecessary child clipping mask layer.
The original code created the child clipping mask layer only if GraphicsLayer::supportsRoundedClip() returned false.
And, GraphicsLayer::supportsRoundedClip() never returned false for all port.
Contributor
Author
There was a problem hiding this comment.
Hello!
Thanks for the review. This is exactly why I didn't move towards a direct revert, and opted to have it run through EWS completely first. Also, it wasn't a clean and easy revert. It had some conflicts and I tried to deal with them as best as I could.
robert-jenner
deleted the
eng/REGRESSION252070main--iOS16-Debug---Updates-to-WebCoreRenderLayerBackingupdateGeometry-cause-testing-to-exit-early-and-not-complete
branch
webkit-commit-queue
pushed a commit
to rahimabdi/WebKit
that referenced
this pull request
Aug 26, 2025
https://bugs.webkit.org/show_bug.cgi?id=296851 rdar://157952768 Reviewed by Tyler Wilcock and Ryosuke Niwa. Adds 'status: developer' feature flag for enumerated ARIA attributes: w3c/aria#2484. The ARIA spec intends to convert the following attributes to be enumerated, i.e., content attributes with permissible keywords and invalid/missing value defaults: - aria-atomic - aria-autocomplete - aria-busy - aria-checked - aria-current - aria-disabled - aria-expanded - aria-haspopup - aria-hidden - aria-invalid - aria-live - aria-modal - aria-multiline - aria-multiselectable - aria-orientation - aria-pressed - aria-readonly - aria-required - aria-selected - aria-sort This PR changes ARIA's IDL to use [ReflectSetter] for enumerated attributes in order to implement the desired reflection behavior behind a flag using manual getters; this also allows maintaining current ARIA IDL behavior when the flag is disabled. When ARIA PR WebKit#2484 lands, ARIA's IDL should be updated to use [Reflect, Enumerated] for automatic JS bindings codegen that doesn't need manual code. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/accessibility/AriaAttributes.idl: * Source/WebCore/dom/Element.h: * Source/WebCore/dom/Element.cpp: (WebCore::Element::ariaAtomic const): (WebCore::Element::ariaAutoComplete const): (WebCore::Element::ariaBusy const): (WebCore::Element::ariaChecked const): (WebCore::Element::ariaCurrent const): (WebCore::Element::ariaDisabled const): (WebCore::Element::ariaExpanded const): (WebCore::Element::ariaHasPopup const): (WebCore::Element::ariaHidden const): (WebCore::Element::ariaInvalid const): (WebCore::Element::ariaLive const): (WebCore::Element::ariaModal const): (WebCore::Element::ariaMultiLine const): (WebCore::Element::ariaMultiSelectable const): (WebCore::Element::ariaOrientation const): (WebCore::Element::ariaPressed const): (WebCore::Element::ariaReadOnly const): (WebCore::Element::ariaRequired const): (WebCore::Element::ariaSelected const): (WebCore::Element::ariaSort const): * Tools/DumpRenderTree/TestOptions.cpp: * Tools/WebKitTestRunner/TestOptions.cpp: Canonical link: https://commits.webkit.org/299159@main
Jarred-Sumner
pushed a commit
to oven-sh/WebKit
that referenced
this pull request
Aug 29, 2025
https://bugs.webkit.org/show_bug.cgi?id=296851 rdar://157952768 Reviewed by Tyler Wilcock and Ryosuke Niwa. Adds 'status: developer' feature flag for enumerated ARIA attributes: w3c/aria#2484. The ARIA spec intends to convert the following attributes to be enumerated, i.e., content attributes with permissible keywords and invalid/missing value defaults: - aria-atomic - aria-autocomplete - aria-busy - aria-checked - aria-current - aria-disabled - aria-expanded - aria-haspopup - aria-hidden - aria-invalid - aria-live - aria-modal - aria-multiline - aria-multiselectable - aria-orientation - aria-pressed - aria-readonly - aria-required - aria-selected - aria-sort This PR changes ARIA's IDL to use [ReflectSetter] for enumerated attributes in order to implement the desired reflection behavior behind a flag using manual getters; this also allows maintaining current ARIA IDL behavior when the flag is disabled. When ARIA PR WebKit#2484 lands, ARIA's IDL should be updated to use [Reflect, Enumerated] for automatic JS bindings codegen that doesn't need manual code. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/accessibility/AriaAttributes.idl: * Source/WebCore/dom/Element.h: * Source/WebCore/dom/Element.cpp: (WebCore::Element::ariaAtomic const): (WebCore::Element::ariaAutoComplete const): (WebCore::Element::ariaBusy const): (WebCore::Element::ariaChecked const): (WebCore::Element::ariaCurrent const): (WebCore::Element::ariaDisabled const): (WebCore::Element::ariaExpanded const): (WebCore::Element::ariaHasPopup const): (WebCore::Element::ariaHidden const): (WebCore::Element::ariaInvalid const): (WebCore::Element::ariaLive const): (WebCore::Element::ariaModal const): (WebCore::Element::ariaMultiLine const): (WebCore::Element::ariaMultiSelectable const): (WebCore::Element::ariaOrientation const): (WebCore::Element::ariaPressed const): (WebCore::Element::ariaReadOnly const): (WebCore::Element::ariaRequired const): (WebCore::Element::ariaSelected const): (WebCore::Element::ariaSort const): * Tools/DumpRenderTree/TestOptions.cpp: * Tools/WebKitTestRunner/TestOptions.cpp: Canonical link: https://commits.webkit.org/299159@main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2ed1487