Repository navigation
Make wtf-8 and wtf-16 handling more uniform - #22
Merged
Merged
Conversation
* string.new_wtf8 takes a wtf8_policy immediate, to allow for U+FFFD replacement of any invalid WTF-8 subsequence. * Remove string.measure_utf8, replacing with string.measure_wtf8 with a wtf8_policy immediate. * string.measure_wtf16 returns length in code units, not bytes. * Specify little-endian for string.encode_wtf16.
jakobkummerow
approved these changes
Jun 22, 2022
|
|
||
| instr ::= ... | ||
| | 0xfb 0x80 $mem:u32 ⇒ string.new_wtf8 $mem | ||
| | 0xfb 0x80 $mem:u32 $policy:u32 ⇒ string.new_wtf8 $mem $policy |
Collaborator
There was a problem hiding this comment.
We could limit the $policy immediate to one byte as u8. Probably doesn't make a difference in practice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replacement of any invalid WTF-8 subsequence.
wtf8_policy immediate.