Skip to content

Don't test split modules for tests with (module instance ...)#8270

Merged
stevenfontanella merged 1 commit intomainfrom
unsplittable-tests
Feb 6, 2026
Merged

Don't test split modules for tests with (module instance ...)#8270
stevenfontanella merged 1 commit intomainfrom
unsplittable-tests

Conversation

@stevenfontanella
Copy link
Member

@stevenfontanella stevenfontanella commented Feb 5, 2026

Currently we can't split tests like this. We'd need to optimize module definitions while leaving (module instance ...) statements in-tact. For now, skip splitting for these cases to allow us to run spec tests with the interpreter normally.

Tested with a modified version of instance.wast that passes. Part of #8261.

@stevenfontanella stevenfontanella marked this pull request as ready for review February 6, 2026 00:28
@stevenfontanella stevenfontanella merged commit 067c899 into main Feb 6, 2026
17 checks passed
@stevenfontanella stevenfontanella deleted the unsplittable-tests branch February 6, 2026 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants