This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Post endpoint - remove empty/null values from the return data.#2393
Closed
adamsilverstein wants to merge 3 commits intodevelopfrom
Closed
Post endpoint - remove empty/null values from the return data.#2393adamsilverstein wants to merge 3 commits intodevelopfrom
adamsilverstein wants to merge 3 commits intodevelopfrom
Conversation
Fixes an issues with the JS CLient that prevents saving a created post because sending the null/empty valuesback to the server fails a validation test.
Author
|
For more details about the reasoning behind this PR, see #2303. |
Member
|
I don't think we should be stripping data from the response. What if we set any date field to |
Member
|
For slugs, the problem needs to be addressed with #1585 |
Contributor
|
Depends on resolution of #2657, there are some differences of opinion there |
Contributor
|
Per #2657 we should not omit values from the data returned to the client; missing data should be exposed as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issues with the JS CLient that prevented saving a created post. Receiving and then sending the null/empty values back to the server fails a validation test, and the save fails. This change strips empty values from the return.