Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Subclass WP_REST_Server to apply curies to WP 4.4 responses#2295

Closed
danielbachhuber wants to merge 5 commits intodevelopfrom
1488-subclass-curies
Closed

Subclass WP_REST_Server to apply curies to WP 4.4 responses#2295
danielbachhuber wants to merge 5 commits intodevelopfrom
1488-subclass-curies

Conversation

@danielbachhuber
Copy link
Copy Markdown
Member

Sadly, a filter would've made this much easier, but the filter we need
doesn't exist.

Fixes #1488

Sadly, a filter would've made this much easier, but the filter we need
doesn't exist.
@danielbachhuber danielbachhuber added this to the 2.0 Beta 13 milestone Feb 20, 2016
@danielbachhuber
Copy link
Copy Markdown
Member Author

@WP-API/amigos #reviewmerge

@danielbachhuber
Copy link
Copy Markdown
Member Author

There's another test failing because curie transformation happens in WP_REST_Server::get_response_links, which we never call inside of our WP_Test_Spy_REST_Server::dispatch() method. Open to ideas on how to inject that.

@danielbachhuber danielbachhuber removed this from the 2.0 Beta 13 milestone Mar 29, 2016
@danielbachhuber
Copy link
Copy Markdown
Member Author

Closing in favor of #2412

@danielbachhuber danielbachhuber deleted the 1488-subclass-curies branch March 29, 2016 19:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants