This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Respect show_avatars option when adding avatars to Users#2151
Merged
danielbachhuber merged 4 commits intoWP-API:developfrom Jan 29, 2016
nullvariable:develop
Merged
Respect show_avatars option when adding avatars to Users#2151danielbachhuber merged 4 commits intoWP-API:developfrom nullvariable:develop
show_avatars option when adding avatars to Users#2151danielbachhuber merged 4 commits intoWP-API:developfrom
nullvariable:develop
Conversation
Member
There was a problem hiding this comment.
Indentation is a bit off here. Also rest_get_avatar_urls() needs spaces around the parameter: rest_get_avatar_urls( $user->user_email );
danielbachhuber
changed the title
show_avatars option when adding avatars to Users
danielbachhuber
added a commit
that referenced
this pull request
Jan 29, 2016
Respect `show_avatars` option when adding avatars to Users
BE-Webdesign
added a commit
to BE-Webdesign/WP-API
that referenced
this pull request
Feb 11, 2016
Possible fix for WP-API#2248. Respects the show_avatars option when retrieving avatars data for comments. Modeled after WP-API#2151.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
show_avatars=>false, thenavatar_urlshouldn't be included on the User Resource.See #1872