This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Missing 'wp/v2' in path in Location Response header#1790
Merged
danielbachhuber merged 1 commit intoWP-API:developfrom Dec 7, 2015
Merged
Missing 'wp/v2' in path in Location Response header#1790danielbachhuber merged 1 commit intoWP-API:developfrom
danielbachhuber merged 1 commit intoWP-API:developfrom
Conversation
Currently either $this->parent_base returns the wrong (empty) base, or 'wp/v2/' is missing from the base.
Actual Location header
c.a.w.w.v.Client.debugRequest() - Request Entity: <POST http://johan-wp/wp-json/wp/v2/posts/3766/meta,{key=Gomxw, value=bLfaU},{Authorization=[Basic am9oYW4ubXluaGFyZHQ6d29yZHByZXNzIQ==]}>
c.a.w.w.v.Client.debugHeaders() - Response Headers:
...
c.a.w.w.v.Client.lambda$debugHeaders$8() - Location -> [http://johan-wp/wp-json/posts/3766/meta/11965]
...
Expected Location header
c.a.w.w.v.Client.debugRequest() - Request Entity: <POST http://johan-wp/wp-json/wp/v2/posts/3766/meta,{key=Gomxw, value=bLfaU},{Authorization=[Basic am9oYW4ubXluaGFyZHQ6d29yZHByZXNzIQ==]}>
c.a.w.w.v.Client.debugHeaders() - Response Headers:
...
c.a.w.w.v.Client.lambda$debugHeaders$8() - Location -> [http://johan-wp/wp-json/wp/v2/posts/3766/meta/11965]
...
Member
|
Thanks for the fix! |
danielbachhuber
added a commit
that referenced
this pull request
Dec 7, 2015
Missing 'wp/v2' in path in Location Response header
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When submitting a Post Meta Create request, the response contains
a Location header with 'wp/v2' missing from the path.
Currently either
$this->parent_basereturns the wrong (empty) base,or
wp/v2/is missing from the base when setting the Location headerfor a Post Meta Create response.
Actual Location header
Expected Location header