Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Ensure post content doesn't get double-slashed on update #1772

Merged
joehoyle merged 4 commits into from
Dec 1, 2015
Merged

Ensure post content doesn't get double-slashed on update #1772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aacc13c
Post updates should expect slashed data
joehoyle Nov 27, 2015
469a58f
Merge branch 'develop' into fix-slashes-in-update-post
danielbachhuber Nov 29, 2015
da604bb
Merge branch 'develop' into fix-slashes-in-update-post
danielbachhuber Nov 30, 2015
301f33b
Update to explicitly test for properly-formed title
danielbachhuber Nov 30, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/endpoints/class-wp-rest-posts-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,8 +251,8 @@ public function update_item( $request ) {
if ( is_wp_error( $post ) ) {
return $post;
}

$post_id = wp_update_post( $post, true );
// convert the post object to an array, otherwise wp_update_post will expect non-escaped input
$post_id = wp_update_post( (array) $post, true );
if ( is_wp_error( $post_id ) ) {
if ( in_array( $post_id->get_error_code(), array( 'db_update_error' ) ) ) {
$post_id->add_data( array( 'status' => 500 ) );
Expand Down
26 changes: 26 additions & 0 deletions tests/test-rest-posts-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,6 +727,19 @@ public function test_create_post_with_invalid_date_gmt() {
$this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
}

public function test_create_post_with_quotes_in_title() {
wp_set_current_user( $this->editor_id );

$request = new WP_REST_Request( 'POST', '/wp/v2/posts' );
$params = $this->set_post_data( array(
'title' => "Rob O'Rourke's Diary",
) );
$request->set_body_params( $params );
$response = $this->server->dispatch( $request );
$new_data = $response->get_data();
$this->assertEquals( "Rob O'Rourke's Diary", $new_data['title']['raw'] );
}

public function test_update_item() {
wp_set_current_user( $this->editor_id );

Expand Down Expand Up @@ -1023,6 +1036,19 @@ public function test_update_password_protected_post_with_sticky_fails() {
$this->assertErrorResponse( 'rest_invalid_field', $response, 400 );
}

public function test_update_post_with_quotes_in_title() {
wp_set_current_user( $this->editor_id );

$request = new WP_REST_Request( 'PUT', sprintf( '/wp/v2/posts/%d', $this->post_id ) );
$params = $this->set_post_data( array(
'title' => "Rob O'Rourke's Diary",
) );
$request->set_body_params( $params );
$response = $this->server->dispatch( $request );
$new_data = $response->get_data();
$this->assertEquals( "Rob O'Rourke's Diary", $new_data['title']['raw'] );
}

public function test_delete_item() {
$post_id = $this->factory->post->create( array( 'post_title' => 'Deleted post' ) );
wp_set_current_user( $this->editor_id );
Expand Down