Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Pagination headers for comment collection queries#1197

Merged
danielbachhuber merged 2 commits intodevelopfrom
1186-comments-pagination
May 7, 2015
Merged

Pagination headers for comment collection queries#1197
danielbachhuber merged 2 commits intodevelopfrom
1186-comments-pagination

Conversation

@danielbachhuber
Copy link
Copy Markdown
Member

Fixes #1186

@danielbachhuber
Copy link
Copy Markdown
Member Author

@WP-API/amigos #reviewmerge

@danielbachhuber
Copy link
Copy Markdown
Member Author

Hm. I have no idea why this test is failing.

@joehoyle
Copy link
Copy Markdown
Member

joehoyle commented May 7, 2015

@danielbachhuber due to the larger amount of tests the "invalid" id's actually existed. I updated to a sufficiently high number to avoid this.

@danielbachhuber
Copy link
Copy Markdown
Member Author

Classic. Thanks!

danielbachhuber pushed a commit that referenced this pull request May 7, 2015
Pagination headers for comment collection queries
@danielbachhuber danielbachhuber merged commit fb1d99e into develop May 7, 2015
@danielbachhuber danielbachhuber deleted the 1186-comments-pagination branch May 7, 2015 20:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Paginate comment queries and limit by default

2 participants