feat: Introduce emulation.setClientHintsOverride#387
Merged
Conversation
…ding user agent client hints and refactor related internal references
miketaylr
approved these changes
Jan 16, 2026
Collaborator
miketaylr
left a comment
miketaylr
left a comment
There was a problem hiding this comment.
Thank you! I'm less familiar with speccing the automation bits, but this LGTM.
github-actions bot
added a commit
that referenced
this pull request
Jan 16, 2026
SHA: ea0eb00 Reason: push, by miketaylr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
sadym-chromium
commented
Jan 16, 2026
| If the [=user agent=]'s [=emulated client hints=] is not null, the [=user agent=] MUST | ||
| return the corresponding value from the [=emulated client hints=] instead of the default | ||
| value for the requested property. | ||
| f |
|
@sadym-chromium I was surprised to see that there is this PR which already got landed without discussing the implementation. Based on https://w3c.github.io/webdriver-bidi/#protocol-modules commands from external specifications should have their own module and should not extend existing modules. There is now issue #391 to fix that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #386
Preview | Diff