Skip to content

update files - #6

Open
WDRevAI wants to merge 1 commit into
masterfrom
change_reda_6
Open

WDRevAI wants to merge 1 commit into
masterfrom
change_reda_6

Conversation

@WDRevAI

@WDRevAI WDRevAI commented May 22, 2024

Copy link
Copy Markdown
Owner

🛠️ Fixes Issue (Number)

👨‍💻 Changes proposed and Brief Description

✅ Check List (Check all the applicable boxes)

  • My code doesn't break any part of the project
  • This PR does not contain plagiarized content.
  • My Addition/Changes works properly and matches the overall repo pattern.
  • The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

@WDRevAI

WDRevAI commented May 22, 2024

Copy link
Copy Markdown
Owner Author

File:01 - Drum Kit/main.js
File:10 - Emoji Switcher like Discord/script.js
code looks good

@WDRevAI

WDRevAI commented May 22, 2024

Copy link
Copy Markdown
Owner Author

test this please

Comment thread 01 - Drum Kit/main.js
import sys;


const keys = Array.from(document.querySelectorAll('.key'));

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this import needed?

@WDRevAI

WDRevAI commented May 22, 2024

Copy link
Copy Markdown
Owner Author

test this please

Comment thread 01 - Drum Kit/main.js
@@ -34,6 +37,12 @@ function playSound(e) {
}

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this.


emojiAddFunction();

emojiAddFunction();

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

@WDRevAI

WDRevAI commented May 23, 2024

Copy link
Copy Markdown
Owner Author

test this please

Comment thread 01 - Drum Kit/main.js
import sys;


const keys = Array.from(document.querySelectorAll('.key'));

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this import needed?

Comment thread 01 - Drum Kit/main.js
@@ -34,6 +37,12 @@ function playSound(e) {
}

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this.


emojiAddFunction();

emojiAddFunction();

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Comment thread 01 - Drum Kit/main.js
@@ -1,3 +1,6 @@
import sys;

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this.

Comment thread 01 - Drum Kit/main.js
@@ -1,3 +1,6 @@
import sys;

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this import needed?

Comment thread 01 - Drum Kit/main.js
@@ -1,3 +1,6 @@
import sys;

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant