add variables not used by WDRevAI · Pull Request #3 · WDRevAI/30DaysOfJavaScript

WDRevAI · 2024-05-20T21:45:38Z

No description provided.

WDRevAI · 2024-05-21T08:49:16Z

test please

WDRevAI · 2024-05-21T08:53:44Z

ok to test

WDRevAI · 2024-05-21T09:01:42Z

test this please

WDRevAI · 2024-05-21T09:03:20Z

test this please

WDRevAI · 2024-05-21T09:05:17Z

test this please

WDRevAI · 2024-05-21T09:05:45Z

don't test

WDRevAI · 2024-05-21T13:32:53Z

test this please

WDRevAI · 2024-05-21T13:33:49Z

test this please

WDRevAI · 2024-05-21T13:34:53Z

test this please

WDRevAI · 2024-05-21T15:06:55Z

test this please

WDRevAI · 2024-05-22T14:49:57Z

Your comment goes here.

WDRevAI · 2024-05-22T15:45:43Z


 function randomNumber (l) {
-    return Math.floor(Math.random() * l);
+    let y = Math.floor(Math.random() * l);


Change the Y variable to a constant

WDRevAI · 2024-05-22T15:54:42Z


 function randomNumber (l) {
-    return Math.floor(Math.random() * l);
+    let y = Math.floor(Math.random() * l);


Change the Y variable to a constant

WDRevAI · 2024-05-22T15:55:57Z

    return words[number];
 }
+
+function randomWord222 () {


Change the Y variable to a constant

WDRevAI · 2024-05-22T15:56:23Z

+
+function randomWord222 () {
+    const number = randomNumber(words.length);
+    return words[number];


Your comment in the file goes here.-- Sarra

WDRevAI · 2024-05-22T16:13:33Z

test PR body comment.

WDRevAI · 2024-05-22T16:15:27Z

-        }
-
        //month span
        elem = document.createElement("span");


Your comment in the file goes here 2.-- Sarra

WDRevAI · 2024-05-22T16:15:47Z

+function randomWord222 () {
+    const number = randomNumber(words.length);
+    return words[number];
+}


WDRevAI · 2024-05-22T16:33:25Z

-            div.appendChild(elem);
-        }
-
        //month span


WDRevAI · 2024-05-22T16:49:03Z


 function randomNumber (l) {
-    return Math.floor(Math.random() * l);
+    let y = Math.floor(Math.random() * l);


test PR inline comment. --MKZ

WDRevAI · 2024-05-22T16:49:49Z

+
+    let z = Math.floor(Math.random() * y);
+    return y;
 }


test PR inline comment. --MKZ

WDRevAI · 2024-05-22T17:33:59Z

Reda Please check this

WDRevAI · 2024-05-22T17:39:31Z

File:05 - Random Password Generator/main.js

@@ -40,10 +40,18 @@ const words = ['seat', 'pen', 'broad', 'vapor', 'ocean',

function randomNumber (l) {

return Math.floor(Math.random() * l);

let y = Math.floor(Math.random() * l);
let z = Math.floor(Math.random() * y);
return y;
}

function randomWord () {
const number = randomNumber(words.length);
return words[number];
}
+
+function randomWord222 () {

const number = randomNumber(words.length);
return words[number];
+}

#######
Comment:
#######
I think this should be randomWord222
#######
File:06 - Calendar/dycalendar.js

WDRevAI · 2024-05-22T17:43:01Z

-            div.appendChild(elem);
-        }
-
        //month span


WDRevAI · 2024-05-22T17:45:33Z

File:05 - Random Password Generator/main.js
File:06 - Calendar/dycalendar.js
code looks good

WDRevAI · 2024-05-22T17:46:53Z

File:05 - Random Password Generator/main.js
File:06 - Calendar/dycalendar.js
code looks good

WDRevAI · 2024-05-22T17:47:37Z

-            div.appendChild(elem);
-        }
-
        //month span


File:05 - Random Password Generator/main.js

@@ -40,10 +40,18 @@ const words = ['seat', 'pen', 'broad', 'vapor', 'ocean',

function randomNumber (l) {

return Math.floor(Math.random() * l);

let y = Math.floor(Math.random() * l);

let z = Math.floor(Math.random() * y);

return y;
}

function randomWord () {
const number = randomNumber(words.length);
return words[number];
}
+
+function randomWord222 () {

const number = randomNumber(words.length);

return words[number];
+}

#######
Comment:
#######
I think this should be randomWord222
#######
File:06 - Calendar/dycalendar.js

WDRevAI · 2024-05-22T20:55:59Z

+    return y;
 }

 function randomWord () {


Unnecessary whitespace change

WDRevAI · 2024-05-22T20:59:25Z

@@ -40,10 +40,18 @@ const words = ['seat', 'pen', 'broad', 'vapor', 'ocean',




Unnecessary whitespace change

WDRevAI · 2024-05-22T20:59:28Z

@@ -148,19 +148,6 @@
        div.setAttribute("class", "dycalendar-header");
        div.setAttribute("data-option", JSON.stringify(option));


Please remove this extra line.

WDRevAI · 2024-05-23T11:22:44Z

File:05 - Random Password Generator/main.js
File:06 - Calendar/dycalendar.js
code looks good

WDRevAI · 2024-05-23T11:23:05Z


 function randomNumber (l) {
-    return Math.floor(Math.random() * l);
+    let y = Math.floor(Math.random() * l);


Unnecessary whitespace change

WDRevAI · 2024-05-23T11:23:08Z

-            div.appendChild(elem);
-        }
-
        //month span


Please remove this extra line.

add variables not used

9488038

modify more files

b3ae45a

WDRevAI commented May 22, 2024

View reviewed changes

Comment thread 06 - Calendar/dycalendar.js

div.appendChild(elem);

}

//month span

WDRevAI May 22, 2024

Copy link
Copy Markdown

Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

WDRevAI commented May 22, 2024

View reviewed changes

Comment thread 06 - Calendar/dycalendar.js

div.appendChild(elem);

}

//month span

WDRevAI May 22, 2024

Copy link
Copy Markdown

Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

WDRevAI commented May 22, 2024

View reviewed changes

WDRevAI commented May 23, 2024

View reviewed changes

Comment thread 06 - Calendar/dycalendar.js

div.appendChild(elem);

}

//month span

WDRevAI May 23, 2024

Copy link
Copy Markdown

Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this extra line.

		@@ -148,19 +148,6 @@
		div.setAttribute("class", "dycalendar-header");
		div.setAttribute("data-option", JSON.stringify(option));

Conversation

WDRevAI commented May 20, 2024

Uh oh!

WDRevAI commented May 21, 2024

Uh oh!

WDRevAI commented May 21, 2024

Uh oh!

WDRevAI commented May 21, 2024

Uh oh!

WDRevAI commented May 21, 2024

Uh oh!

WDRevAI commented May 21, 2024

Uh oh!

WDRevAI commented May 21, 2024

Uh oh!

WDRevAI commented May 21, 2024

Uh oh!

WDRevAI commented May 21, 2024

Uh oh!

WDRevAI commented May 21, 2024

Uh oh!

WDRevAI commented May 21, 2024

Uh oh!

WDRevAI commented May 22, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WDRevAI commented May 22, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WDRevAI commented May 22, 2024

Uh oh!

WDRevAI commented May 22, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WDRevAI commented May 22, 2024

Uh oh!

WDRevAI commented May 22, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WDRevAI commented May 23, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant