Conversation
|
Code looks good |
|
|
||
| function randomNumber (l) { | ||
| return Math.floor(Math.random() * l); | ||
| let y = Math.floor(Math.random() * l); |
There was a problem hiding this comment.
Change the Y variabel to a constant
|
File:05 - Random Password Generator/main.js |
|
Reda Please check this |
|
File:05 - Random Password Generator/main.js |
14 similar comments
|
File:05 - Random Password Generator/main.js |
|
File:05 - Random Password Generator/main.js |
|
File:05 - Random Password Generator/main.js |
|
File:05 - Random Password Generator/main.js |
|
File:05 - Random Password Generator/main.js |
|
File:05 - Random Password Generator/main.js |
|
File:05 - Random Password Generator/main.js |
|
File:05 - Random Password Generator/main.js |
|
File:05 - Random Password Generator/main.js |
|
File:05 - Random Password Generator/main.js |
|
File:05 - Random Password Generator/main.js |
|
File:05 - Random Password Generator/main.js |
|
File:05 - Random Password Generator/main.js |
|
File:05 - Random Password Generator/main.js |
| let y = Math.floor(Math.random() * l); | ||
|
|
||
| let z = Math.floor(Math.random() * y); | ||
| return y; |
|
File:05 - Random Password Generator/main.js |
| let y = Math.floor(Math.random() * l); | ||
|
|
||
| let z = Math.floor(Math.random() * y); | ||
| return y; |
There was a problem hiding this comment.
I think this should be z = Math.random() * l
| let y = Math.floor(Math.random() * l); | ||
|
|
||
| let z = Math.floor(Math.random() * y); | ||
| return y; |
There was a problem hiding this comment.
I think this should be z = Math.random() * l
| let y = Math.floor(Math.random() * l); | ||
|
|
||
| let z = Math.floor(Math.random() * y); | ||
| return y; |
There was a problem hiding this comment.
I think this should be z = Math.random() * l
|
File:05 - Random Password Generator/main.js |
1 similar comment
|
File:05 - Random Password Generator/main.js |
| let y = Math.floor(Math.random() * l); | ||
|
|
||
| let z = Math.floor(Math.random() * y); | ||
| return y; |
There was a problem hiding this comment.
Unnecessary whitespace change
|
File:05 - Random Password Generator/main.js |
|
|
||
| function randomNumber (l) { | ||
| return Math.floor(Math.random() * l); | ||
| let y = Math.floor(Math.random() * l); |
There was a problem hiding this comment.
Unnecessary whitespace change
1 participant
No description provided.