fix(editor): clear command palette in initCommands to avoid stale act… - #252
Open
VDnoob wants to merge 1 commit into
Open
fix(editor): clear command palette in initCommands to avoid stale act…#252VDnoob wants to merge 1 commit into
VDnoob wants to merge 1 commit into
Conversation
…ivity result handlers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IllegalStateException: Attempting to launch an unregistered ActivityResultLauncher means openFile.launch(...) ran while that ActivityResultLauncher was no longer registered with the activity’s ActivityResultRegistry.
##Fix applied
initCommands() already had a commented-out reset. Turning it on clears the palette when each EditorActivity is created, so old launcher-backed commands are dropped before initCommands() re-registers static commands. FileMenu / drawer / top bar LaunchedEffects then register fresh handlers with the current launchers. Plugins still call addCommand after load as before.
Change: call CommandPaletteManager.instance.clear() at the start of initCommands() in EditorActivity.kt.
Summary by CodeRabbit