API: bugref:11116 Sanitize imported data from OVA/OVF by removing serial port settings if they are directed to host raw file.

baserkan · baserkan · commit d0ba2b821a08 · 2026-07-14T10:57:00.000Z
svn:sync-xref-src-repo-rev: r174528
diff --git a/include/VBox/settings.h b/include/VBox/settings.h
@@ -1585,7 +1585,7 @@ class MachineConfigFile : public ConfigFileBase
     void buildMachineXML(xml::ElementNode &elmMachine,
                          uint32_t fl,
                          std::list<xml::ElementNode*> *pllElementsWithUuidAttributes);
-
+    void sanitizeImportedSerialPorts();
     static bool isAudioDriverAllowedOnThisHost(AudioDriverType_T enmDrvType);
     static AudioDriverType_T getHostDefaultAudioDriver();
 
diff --git a/src/VBox/Main/src-server/ApplianceImplImport.cpp b/src/VBox/Main/src-server/ApplianceImplImport.cpp
@@ -1,4 +1,4 @@
-/* $Id: ApplianceImplImport.cpp 112403 2026-01-11 19:29:08Z knut.osmundsen@oracle.com $ */
+/* $Id: ApplianceImplImport.cpp 114692 2026-07-14 10:57:00Z serkan.bayraktar@oracle.com $ */
 /** @file
  * IAppliance and IVirtualSystem COM class implementations.
  */
@@ -381,7 +381,23 @@ HRESULT Appliance::interpret()
             /* The NVRAM file does not have a <vbox:Machine> entry so we only need to check the OVF details. */
             if (vsysThis.strNvramPath.isNotEmpty())
                 pNewDesc->i_addEntry(VirtualSystemDescriptionType_NVRAM, "", vsysThis.strNvramPath, vsysThis.strNvramPath);
-
+            /* Check if any of the serial ports is configured with mode raw file. */
+            if (vsysThis.pelmVBoxMachine)
+            {
+                settings::SerialPortsList const &llSerialPorts =
+                pNewDesc->m->pConfig->hardwareMachine.llSerialPorts;
+                for (settings::SerialPortsList::const_iterator port_it = llSerialPorts.begin();
+                        port_it != llSerialPorts.end();
+                    ++port_it)
+                {
+                    if (port_it->portMode == PortMode_RawFile)
+                    {
+                        i_addWarning(tr("Virtual appliance \"%s\" was configured with serial port(s) "
+                                        "with \"raw file\" mode. These setting will not be imported"), vsysThis.strName.c_str());
+                        break;
+                    }
+                }
+            }
             /* Audio */
             Utf8Str strSoundCard;
             Utf8Str strSoundCardOrig;
@@ -6117,6 +6133,7 @@ void Appliance::i_importVBoxMachine(ComObjPtr<VirtualSystemDescription> &vsdescT
     ComObjPtr<Machine> pNewMachine;
     hrc = pNewMachine.createObject();
     if (FAILED(hrc)) throw hrc;
+    config.sanitizeImportedSerialPorts();
 
     // this magic constructor fills the new machine object with the MachineConfig
     // instance that we created from the vbox:Machine
diff --git a/src/VBox/Main/xml/Settings.cpp b/src/VBox/Main/xml/Settings.cpp
@@ -1,4 +1,4 @@
-/* $Id: Settings.cpp 114362 2026-06-15 18:31:38Z andreas.loeffler@oracle.com $ */
+/* $Id: Settings.cpp 114692 2026-07-14 10:57:00Z serkan.bayraktar@oracle.com $ */
 /** @file
  * Settings File Manipulation API.
  *
@@ -9696,6 +9696,22 @@ bool MachineConfigFile::isAudioDriverAllowedOnThisHost(AudioDriverType_T enmDrvT
     return false;
 }
 
+void MachineConfigFile::sanitizeImportedSerialPorts()
+{
+    for (SerialPortsList::iterator it = hardwareMachine.llSerialPorts.begin();
+            it != hardwareMachine.llSerialPorts.end();
+            ++it)
+    {
+        SerialPort &port = *it;
+        if (port.portMode == PortMode_RawFile)
+        {
+            port.portMode = PortMode_Disconnected;
+            port.fEnabled = false;
+            port.strPath.setNull();
+        }
+    }
+}
+
 /**
  * Called from write() before calling ConfigFileBase::createStubDocument().
  * This adjusts the settings version in m->sv if incompatible settings require
