Skip to content

app/vmui: improve chart performance and fix median calculation #9946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

app/vmui: improve chart performance and fix median calculation #9946

wants to merge 1 commit into from
+1,473 −1,035

Conversation

@Loori-R
Copy link
Contributor

@Loori-R Loori-R commented Oct 31, 2025 •
edited
Loading

Describe Your Changes

This PR improves overall performance and stability of chart rendering, refines time series generation, and fixes incorrect median calculation in metric series.
JavaScript execution time improved by up to ×6 on large datasets.

Changes:

  • Reworked getTimeSeries - one point per pixel.
  • Added legend auto-collapse when >20 items.
  • Switched median algorithm to Quickselect (Floyd–Rivest).
  • Unified array stats functions (min, max, avg, median) into a single pass.
  • Removed unused last value from series.
  • Renamed roundToMilliseconds to roundToThousandths and moved to utils/math.
  • Replaced isSupportedDuration with parseSupportedDuration, added fractional duration support.

Related issues: #9699, #9926

Checklist

The following checks are mandatory:

@Loori-R
app/vmui: improve chart performance and fix median calculation
9f4144f 
- improve overall chart rendering and data processing performance (#9699)
- fix incorrect median value calculation in series (#9926)

Signed-off-by: Yury Molodov <yurymolodov@gmail.com>
@Loori-R Loori-R added the vmui UI for ad-hoc queries in VictoriaMetrics or VictoriaLogs label Oct 31, 2025
This was linked to issues Oct 31, 2025
VMUI stability issues in Safari #9699
Open
app/vmui: incorrect median calculation for series #9926
Open
@Loori-R Loori-R mentioned this pull request Oct 31, 2025
Open
@makasim makasim self-assigned this Nov 4, 2025
arturminchukov
arturminchukov approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@arturminchukov arturminchukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arturminchukov arturminchukov arturminchukov approved these changes

@valyala valyala Awaiting requested review from valyala

@AndrewChubatiuk AndrewChubatiuk Awaiting requested review from AndrewChubatiuk

Assignees

@makasim makasim

Labels

vmui UI for ad-hoc queries in VictoriaMetrics or VictoriaLogs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

app/vmui: incorrect median calculation for series VMUI stability issues in Safari

3 participants

@Loori-R @arturminchukov @makasim