app/vminsert: improve slowness-based rerouting logic #9945
Conversation
makasim
force-pushed
the
slowest-rerouting
branch
from
f88d7c1 to
e25d34b
Compare
| // | ||
| // See the comments below for detailed conditions. | ||
| func allowRerouting(snSource *storageNode, sns []*storageNode) bool { | ||
| if *disableRerouting { |
There was a problem hiding this comment.
Should rerouting be disabled for RF>1 ? AFAIK it does not work reliably at the moment.
makasim
force-pushed
the
slowest-rerouting
branch
2 times, most recently
from
85c831b to
701080a
Compare
makasim
changed the title
makasim
changed the title
Adjust slowness-based rerouting logic. Rerouting now occurs only from the slowest node, and only if the cluster as a whole has enough available capacity to handle the additional load. See the detailed proposal: #9890
makasim
force-pushed
the
slowest-rerouting
branch
from
701080a to
cc5fa73
Compare
|
I know that the tests are yet to be added, but could you share some manual steps to reproduce that this PR acrually improves the ingestion rate? Maybe also share the metrics to look at in order to confirm the improvement. |
Do you mean integration tests ? Not sure if one could be written. It would be slow (needs warmup for averages) and fragile. Or some options that reduce warmup time just for the sake of tests. As for manual tests, I'll do some tests myself and share the results here, and also share the scripts I used for it. |
2 participants
Describe Your Changes
Adjust slowness-based rerouting logic.
Rerouting now occurs only from the slowest node, and only if the cluster as a whole has enough available capacity to handle the additional load.
See the detailed proposal: #9890
TODO:
Checklist
The following checks are mandatory: