Skip to content

Fixed (1) / Add (2) Filters, Modified UI #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Sommos merged 7 commits into from
Aug 21, 2023
Merged

Fixed (1) / Add (2) Filters, Modified UI #5

Sommos merged 7 commits into from
Aug 21, 2023

Conversation

@Sommos
Copy link
Contributor

@Sommos Sommos commented Aug 21, 2023 •
edited
Loading

Fixed

  • Dark filter so it actually modifies the bits
  • Sepia filter to not match the algorithm for bright filter

Added

  • Pixelate filter
  • Emboss filter

Modified

  • UI to have an additional row of buttons to enable additional filter options

@Sommos Sommos requested review from a team and VerzatileDev August 21, 2023 19:31
Sommos
Sommos commented Aug 21, 2023
View reviewed changes
Copy link
Contributor Author

@Sommos Sommos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, runs good for me. Need to build unit tests as the project grows.

@VerzatileDev VerzatileDev changed the title Fixed filters, added 2 additional filters, and modified UI Fixed filters, add 2 filters, modified UI Aug 21, 2023
@VerzatileDev VerzatileDev changed the title Fixed filters, add 2 filters, modified UI Fixed (1) / add (2) filters, modified UI Aug 21, 2023
@VerzatileDev VerzatileDev added the enhancement New feature or request label Aug 21, 2023
@VerzatileDev VerzatileDev added this to the App render Basic milestone Aug 21, 2023
@Sommos Sommos added the bug Something isn't working label Aug 21, 2023
VerzatileDev
VerzatileDev reviewed Aug 21, 2023
View reviewed changes
VerzatileDev
VerzatileDev reviewed Aug 21, 2023
View reviewed changes
VerzatileDev
VerzatileDev reviewed Aug 21, 2023
View reviewed changes
VerzatileDev
VerzatileDev reviewed Aug 21, 2023
View reviewed changes
VerzatileDev
VerzatileDev reviewed Aug 21, 2023
View reviewed changes
VerzatileDev
VerzatileDev approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@VerzatileDev VerzatileDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, thanks for the fixes!

@Sommos Sommos merged commit fa85bba into VerzatileDevOrg:main Aug 21, 2023
@Sommos Sommos changed the title Fixed (1) / add (2) filters, modified UI Fixed (1) / Add (2) filters, Modified UI Aug 23, 2023
@Sommos Sommos changed the title Fixed (1) / Add (2) filters, Modified UI Fixed (1) / Add (2) Filters, Modified UI Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VerzatileDev VerzatileDev VerzatileDev approved these changes

Assignees

@Sommos Sommos

@VerzatileDev VerzatileDev

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Milestone

App render Basic

Development

Successfully merging this pull request may close these issues.

2 participants

@Sommos @VerzatileDev