Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 13 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="drift/instrumentation/aiohttp/instrumentation.py">
<violation number="1" location="drift/instrumentation/aiohttp/instrumentation.py:814">
P2: HTTP header lookup should be case-insensitive. The `content_type` property uses `self._headers.get("content-type", ...)` which won't match headers stored with different casing like "Content-Type". This will cause incorrect content type detection during REPLAY mode.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
sohankshirsagar
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
aiohttp Instrumentation
ClientSession._request()to capture/replay all HTTP client calls_MockClientResponse) for REPLAY modeSocket Instrumentation Improvement
calling_library != "ProtobufCommunicator"tocalling_library is Nonecalling_library_contextduring requestsDocumentation
notes.mdfor aiohttp documenting theaiohappyeyeballslimitation where some socket warnings persist due to asyncio callback context propagationUnit Tests
test_metrics.pyandtest_resilience.pyTest Results