feat: add pre-request time travel support#28
Merged
sohankshirsagar merged 16 commits intomainfrom Jan 15, 2026
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 9 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="pyproject.toml">
<violation number="1" location="pyproject.toml:30">
P1: Do not depend on a developer-local file path for `tusk-drift-schemas`; publishing/installing the SDK elsewhere will fail because the path is not accessible. Restore a published version spec instead.</violation>
</file>
<file name="drift/core/communication/communicator.py">
<violation number="1" location="drift/core/communication/communicator.py:835">
P1: Background reader enters busy loop when connection closes. When `_recv_exact` returns `None` (indicating a closed connection), the code executes `continue` which causes a tight infinite loop at 100% CPU. The loop should `break` instead to properly terminate when the connection is closed.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name=".github/workflows/ci.yml">
<violation number="1">
P2: CI now installs uv with `version: "latest"`, which removes the explicit pin and makes builds non‑deterministic. Pin the uv binary to a known version (e.g., 0.9.24) so CI doesn’t break when a new uv release introduces breaking changes.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name=".github/workflows/ci.yml">
<violation number="1" location=".github/workflows/ci.yml:31">
P2: `grep` exits non‑zero when no match is found, so this debug step will fail the whole CI job whenever "asgiref" is not present in `uv.lock`. Guard the command so missing matches don’t break linting.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
jy-tan
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will include kinde instrumentation in another PR
Note
Enables CLI-initiated time travel and improves SDK-CLI comms reliability.
ProtobufCommunicatorto process CLI-initiated messages (handlesSET_TIME_TRAVEL) and route responses via pre-registered Events to avoid races_handle_set_time_travel_syncand_send_message_sync; guard socket sends with a shared lock; enhance cleanup to stop thread and unblock waiters_wait_for_response(_async)and pre-registration before send; fall back to direct socket reads when no background readerConnectRequestto includeruntimeand re-exportRuntime; import/exportSetTimeTravelRequest/Responseis_pre_app_startbased onsdk.app_readyin REPLAY pathtusk-drift-schemasto>=0.1.24; CI/build workflow unchanged functionallyWritten by Cursor Bugbot for commit 4a6c066. This will update automatically on new commits. Configure here.