fix: requests instrumentation fixes#23
Merged
sohankshirsagar merged 4 commits intomainfrom Jan 12, 2026
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="drift/instrumentation/requests/instrumentation.py">
<violation number="1" location="drift/instrumentation/requests/instrumentation.py:185">
P3: Docstring documents `sdk` parameter that doesn't exist in the method signature. Remove the `sdk: TuskDrift instance` line from the Args section.</violation>
</file>
You're on the cubic free plan with 19 free PR reviews remaining this month. Upgrade for unlimited reviews.
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Contributor
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
sohil-kshirsagar
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Shifts interception from
Session.requesttoSession.sendto cover all call paths, including directsession.send(PreparedRequest)._handle_record_sendand_handle_replay_send; extract kwargs fromPreparedRequestvia_extract_kwargs_from_prepared_request_content_consumed=Trueand replay path dispatches response hooks to match Requests behaviorsession-send-direct,streaming-iter-lines, andresponse-hooks; test runner invokes themWritten by Cursor Bugbot for commit 9ab1d73. This will update automatically on new commits. Configure here.